Skip to content

enh(llvm) Improve grammar and align assembly like grammars #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 13, 2020
Merged

enh(llvm) Improve grammar and align assembly like grammars #2830

merged 11 commits into from
Nov 13, 2020

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Nov 4, 2020 •
edited
Loading

Resolves #2782.

Changes

  • Variables are now highlighted as variable
  • i8, i32, etc now highlighted as type
  • Labels are now highlighted as symbol (matching our other grammars)
  • Better comment detection
  • Restore relevance to strings
  • prevent false positives on ; line endings as "comments"
  • Add very minimal operator and punctuation support

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md
  • Added myself to AUTHORS.txt, under Contributors

allejo
allejo requested changes Nov 13, 2020
View reviewed changes
@allejo allejo mentioned this pull request Nov 13, 2020
Closed
8 tasks
@joshgoebel joshgoebel merged commit 7816b2f into highlightjs:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allejo allejo allejo approved these changes

@egor-rogov egor-rogov Awaiting requested review from egor-rogov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(llvm) types and blocks are parsed incorrectly
2 participants
@joshgoebel @allejo