Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(parser) plugin callbacks for highlight #2395

Merged
merged 7 commits into from
Mar 1, 2020
Merged

(parser) plugin callbacks for highlight #2395

merged 7 commits into from
Mar 1, 2020

Conversation

joshgoebel
Copy link
Member

No description provided.

@joshgoebel joshgoebel mentioned this pull request Feb 6, 2020
Closed
@joshgoebel joshgoebel added enhancement An enhancement or new feature parser plugin Specific plugin or plugin discussion labels Feb 6, 2020
egor-rogov
egor-rogov reviewed Feb 15, 2020
View reviewed changes
src/highlight.js Outdated Show resolved Hide resolved
@joshgoebel joshgoebel mentioned this pull request Feb 16, 2020
Closed
@joshgoebel joshgoebel force-pushed the highlight_callbacks branch 2 times, most recently from cd05f9f to 75a0b8d Compare February 19, 2020 12:42
@joshgoebel joshgoebel changed the title WIP: plugin callbacks for highlight (parser) plugin callbacks for highlight Feb 19, 2020
egor-rogov
egor-rogov reviewed Feb 25, 2020
View reviewed changes
Copy link
Collaborator

@egor-rogov egor-rogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Are you going to add these new callbacks to the docs in this PR?

@joshgoebel joshgoebel added this to the 10.0 milestone Feb 29, 2020
@joshgoebel
Copy link
Member Author

Added docs.

@joshgoebel joshgoebel force-pushed the highlight_callbacks branch from 2f2cf57 to cad4aa7 Compare March 1, 2020 14:17
@joshgoebel joshgoebel merged commit ad43aa3 into highlightjs:master Mar 1, 2020
joshgoebel added a commit that referenced this pull request Mar 3, 2020
@joshgoebel
(parser) before/after plugin callbacks for highlight (#2395)
2ca829e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egor-rogov egor-rogov egor-rogov approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature parser plugin Specific plugin or plugin discussion
Projects
None yet
Milestone
10.0 Spring Relase
Development

Successfully merging this pull request may close these issues.
2 participants
@joshgoebel @egor-rogov