(javascript) (typescript?) setTimeout incorrectly detected as a setter

[qWici]

Screenshot of highlighted code

Screenshot of html output

It looks like this regexp wrong.

highlight.js/src/languages/javascript.js

Line 266 in d4b047b

begin:'(get|set)\\s*(?=' + IDENT_RE+ '\\()',

[joshgoebel]

It looks like this regexp wrong.

I concur with your conclusion. Would you be willing to whip up a PR? If so:

• Don't forget CHANGES.md
• We'll need to add a quick markup test for this.

It should likely be \s+ me thinks.

[joshgoebel]

This quite likely is also broken in typescript I'd guess.

[qWici]

@yyyc514 yeah, I tested it on regex101. And I want to try to fix it.

[joshgoebel]

Oh wow that site is super nice!

And I want to try to fix it.

Please take a swing at it. :)

[qWici]

@yyyc514 ok, I fixed it. But I have 2 questions before PR.

1. Should these functions be highlighted? Because it's native JS functions (setTimeout, setInterval)
2. I don't see such a rule for typescript. I can add. Do I need to create a separate PR for this?

[joshgoebel]

Should these functions be highlighted? Because it's native JS functions (setTimeout, setInterval)

You could argue that either way. We barely highlight any built in functions right now. Since those are more like window globals I wouldn't mind if we added them as built-ins.

So yes, lets do it!

I don't see such a rule for typescript. I can add. Do I need to create a separate PR for this?

Oh, it doesn't have it. I wouldn't. Technically the rule would need to be a lot more complex in TypeScript with all it's type details... so unless you want to potentially tackle that I'd probably just focus on JS.

Long-term I'd like to see if we can find a way to build TS and JS on the same foundation since they are so similar (other than typing).

[qWici]

Something going wrong with name of my prev commit. So I remove the branch in my fork and push another branch with 2 commits.

[qWici]

@yyyc514 also I'm not sure if it's okay that my editor has replaced single quotes on double-quotes.