(dart) add title.class scope to built-in classes

highlightjs · Nov 18, 2024 · ea46b1f · ea46b1f
1 parent 1f1a76a
commit ea46b1f
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/src/languages/dart.js b/src/languages/dart.js
@@ -224,10 +224,6 @@ export default function(hljs) {
     $pattern: /[A-Za-z][A-Za-z0-9_]*\??/
   };
 
-  const CAPITALIZED_BUILT_IN_TYPES = BUILT_IN_TYPES.filter(type => /^[A-Z]/.test(type));
-
-  const BUILT_IN_TYPES_REGEX = `\\b(${CAPITALIZED_BUILT_IN_TYPES.join('|')})\\b`;
-
   const CLASS_NAME_RE = regex.either(
     /\b([A-Z]+[a-z0-9]+)+/,
     // ends in caps
@@ -237,11 +233,6 @@ export default function(hljs) {
   const CLASS_REFERENCE = {
     relevance: 0,
     variants: [
-      {
-        // prevent built-in types with capital letter from being selected as title.class
-        match: BUILT_IN_TYPES_REGEX,
-        skip: true
-      },
       {
         match: CLASS_NAME_RE,
         scope: "title.class"

diff --git a/test/markup/dart/class.expect.txt b/test/markup/dart/class.expect.txt
@@ -1,5 +1,5 @@
 <span class="hljs-class"><span class="hljs-keyword">class</span> <span class="hljs-title">Person</span> </span>{
-  <span class="hljs-built_in">String</span> name;
+  <span class="hljs-title class_">String</span> name;
   <span class="hljs-built_in">int</span> age;
 
   <span class="hljs-title class_">Person</span>(<span class="hljs-keyword">this</span>.name, <span class="hljs-keyword">this</span>.age);

diff --git a/test/markup/dart/function.expect.txt b/test/markup/dart/function.expect.txt
@@ -1,4 +1,4 @@
-<span class="hljs-keyword">void</span> <span class="hljs-title function_">greet</span>(<span class="hljs-built_in">String</span> name) {
+<span class="hljs-keyword">void</span> <span class="hljs-title function_">greet</span>(<span class="hljs-title class_">String</span> name) {
   <span class="hljs-title function_">print</span>(<span class="hljs-string">&#x27;Hello, <span class="hljs-subst">$name</span>!&#x27;</span>);
 }