fix CI error (#1045)

* fix CI error * change the CI triggering event to pull_request
highlight · Nov 7, 2022 · e08d039 · e08d039
1 parent 1990524
commit e08d039
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 8 deletions.
diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml
@@ -1,6 +1,6 @@
 name: Tests
 
-on: [push, pull_request_target]
+on: [push, pull_request]
 
 concurrency: ${{ github.workflow }}-${{ github.ref }}
 

diff --git a/packages/rrweb-player/src/utils.ts b/packages/rrweb-player/src/utils.ts
@@ -16,7 +16,7 @@ declare global {
 }
 
 import { EventType, IncrementalSource } from 'rrweb';
-import type { eventWithTime } from 'rrweb/typings/types';
+import type { eventWithTime } from '@rrweb/types';
 
 export function inlineCss(cssObj: Record<string, string>): string {
   let style = '';

diff --git a/packages/rrweb-player/typings/index.d.ts b/packages/rrweb-player/typings/index.d.ts
@@ -1,4 +1,5 @@
-import { eventWithTime, playerConfig } from 'rrweb/typings/types';
+import { playerConfig } from 'rrweb/typings/types';
+import type { eventWithTime } from '@rrweb/types';
 import { Replayer, mirror } from 'rrweb';
 import { SvelteComponent } from 'svelte';
 

diff --git a/packages/rrweb/tsconfig.json b/packages/rrweb/tsconfig.json
@@ -9,24 +9,30 @@
     "preserveConstEnums": true,
     "rootDir": "src",
     "outDir": "build",
-    "lib": ["es6", "dom"],
+    "lib": [
+      "es6",
+      "dom"
+    ],
     "downlevelIteration": true,
     "importsNotUsedAsValues": "error",
     "strictBindCallApply": true,
     "composite": true
   },
   "references": [
     {
-      "path": "../rrdom"
+      "path": "../types"
     },
     {
-      "path": "../rrweb-snapshot"
+      "path": "../rrdom"
     },
     {
-      "path": "../types"
+      "path": "../rrweb-snapshot"
     }
   ],
-  "exclude": ["test", "scripts"],
+  "exclude": [
+    "test",
+    "scripts"
+  ],
   "include": [
     "src",
     "node_modules/@types/css-font-loading-module/index.d.ts",