Skip to content

Conversation

@darshana-v
Copy link
Contributor

Separate the Highflame CLI and SDK into two independent packages for better
modularity and reduced dependencies. Installing sdk will not install cli dependencies.

@darshana-v darshana-v requested a review from rsharath January 12, 2026 17:49
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @darshana-v, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a significant architectural change by decoupling the Highflame CLI from its SDK. The primary goal is to improve the modularity of the Highflame project and streamline dependency management. By creating separate highflame (SDK) and highflame-cli (CLI) packages, users who only need the SDK will no longer be burdened with CLI-specific dependencies. This change also sets the stage for more independent development and distribution of both components.

Highlights

  • Package Separation: The Highflame CLI and SDK have been separated into two distinct Python packages: highflame for the SDK and highflame-cli for the command-line interface. This enhances modularity and reduces dependencies for SDK users.
  • Installation and Usage Documentation: The README.md has been updated to provide separate installation instructions for the SDK (pip install highflame) and the CLI (pip install highflame-cli). It also clarifies that the CLI package depends on the SDK, ensuring automatic installation of the SDK when the CLI is installed. New usage examples for both SDK and CLI are included.
  • Build Configuration Updates: The pyproject.toml files have been adjusted. The main pyproject.toml no longer includes the CLI package or its script entry point. A new highflame_cli/pyproject.toml (renamed from CLI_PYPROJECT.toml) is introduced for the highflame-cli package, defining its metadata and dependencies.
  • CLI Internal Imports: The highflame_cli/_internal/commands.py file now explicitly imports components from the public SDK API, reinforcing the separation and ensuring the CLI functions correctly as an independent package relying on the SDK.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully separates the Highflame CLI and SDK into two distinct packages, which is a great step for modularity. The changes in the pyproject.toml files correctly configure the new package structure for a monorepo setup. The README.md has been updated accordingly. I've found one issue in the updated documentation where a CLI example for creating a route is incorrect, which could lead to user confusion. My review includes a comment to address this.

README.md Outdated
highflame route list

# Create a route
highflame route create --name my_route --file route.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The example for highflame route create uses a --file route.json argument. Based on the CLI implementation in highflame_cli/cli.py, this argument does not seem to exist. The command expects --models and --config arguments with JSON strings. This discrepancy will confuse users. Please update the documentation to provide a correct example. Alternatively, consider implementing the --file argument in the CLI to improve usability.

@darshana-v
Copy link
Contributor Author

#238

@darshana-v
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants