-
Notifications
You must be signed in to change notification settings - Fork 1
Separate cli from sdk #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rename-sdk
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @darshana-v, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a significant architectural change by decoupling the Highflame CLI from its SDK. The primary goal is to improve the modularity of the Highflame project and streamline dependency management. By creating separate Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully separates the Highflame CLI and SDK into two distinct packages, which is a great step for modularity. The changes in the pyproject.toml files correctly configure the new package structure for a monorepo setup. The README.md has been updated accordingly. I've found one issue in the updated documentation where a CLI example for creating a route is incorrect, which could lead to user confusion. My review includes a comment to address this.
README.md
Outdated
| highflame route list | ||
|
|
||
| # Create a route | ||
| highflame route create --name my_route --file route.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example for highflame route create uses a --file route.json argument. Based on the CLI implementation in highflame_cli/cli.py, this argument does not seem to exist. The command expects --models and --config arguments with JSON strings. This discrepancy will confuse users. Please update the documentation to provide a correct example. Alternatively, consider implementing the --file argument in the CLI to improve usability.
…ion A structure in v2 branch
|
All phases completed in https://github.com/highflame-ai/highflame-python/blob/v2/v2/CLI_SEPARATION_PLAN.md |
Separate the Highflame CLI and SDK into two independent packages for better
modularity and reduced dependencies. Installing sdk will not install cli dependencies.