Skip to content

Allow to customize butane config file #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

tobiashuste
Copy link
Member

@tobiashuste tobiashuste commented Aug 26, 2024

This way we can support other operating systems than Flatcar Linux as well, e.g. Fedora CoreOS.

@github-actions github-actions bot added the gitlab_runner Related to hifis.toolkit.gitlab_runner role label Aug 26, 2024
@tobiashuste tobiashuste marked this pull request as ready for review August 26, 2024 12:51
@tobiashuste tobiashuste requested a review from a team as a code owner August 26, 2024 12:51
@tobiashuste tobiashuste added the enhancement New feature or request label Aug 26, 2024
Copy link
Member

@christianhueserhzdr christianhueserhzdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for making the butane config file customizable. I would do it the other way round and introduce the butane config file name as a variable instead of the template file name. Could this also be a way to go?

@tobiashuste
Copy link
Member Author

tobiashuste commented Aug 27, 2024

Thank you very much for making the butane config file customizable. I would do it the other way round and introduce the butane config file name as a variable instead of the template file name. Could this also be a way to go?

This change was intended to allow for supporting more than only Flatcar Linux as Operating System. We could als support https://fedoraproject.org/coreos/ with this change. Thus, the template was important to be changeable. The server side file does not really matter. The template file variable could also contain directories.
I suggest to give the variable a better name: gitlab_runner_butane_config_template

@tobiashuste tobiashuste merged commit b572744 into hifis-net:main Aug 27, 2024
12 checks passed
@tobiashuste tobiashuste deleted the support-other-os branch August 27, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gitlab_runner Related to hifis.toolkit.gitlab_runner role
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants