Skip to content

feat: delete connection per profile with header icon buttons - #1

Merged
hieuck merged 1 commit into
mainfrom
feat/delete-connection
Aug 23, 2026
Merged

feat: delete connection per profile with header icon buttons#1
hieuck merged 1 commit into
mainfrom
feat/delete-connection

Conversation

@hieuck

@hieuck hieuck commented Aug 23, 2026

Copy link
Copy Markdown
Owner

Changements

Ajoute la possibilité de supprimer une connection par profil depuis l'interface.

Fonctionnalités

  • Delete Connection command : supprime uniquement les connections correspondant au profil sélectionné
  • Nouveau endpoint API DeleteConnectionAsync (HTTP DELETE /api/providers/{connectionId})
  • Boutons icône dans la header du provider card (aligned au statut) :
    • ↻ Test connection
    • × Delete connection
  • Suppression automatique de la clé API correspondante dans le vault

Fichiers modifiés

  • IRouterApiClient.cs / RouterApiClient.cs : endpoint DELETE
  • MainViewModel.cs : command + logique de suppression (avec confirmation)
  • MainWindow.xaml : boutons icône alignés au statut
  • RouterApiDeleteConnectionTests.cs : tests unitaires

Tests

  • 5/5 tests DELETE passent

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@codereviewbot-ai

codereviewbot-ai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Summary of Changes & Review

  • IRouterApiClient / RouterApiClient: Added DeleteConnectionAsync with input validation via ArgumentException.ThrowIfNullOrWhiteSpace, URL escaping for connectionId, and proper response checking with EnsureSuccessAsync.
  • MainViewModel: Added DeleteConnectionCommand and implemented DeleteConnectionAsync with profile validation, matching connections check, user confirmation dialog, API deletion loop, API key removal from ISecretVault when applicable, and status refresh.
  • Unit Tests: Added RouterApiDeleteConnectionTests validating request method/path, argument validation, and error response handling.

LGTM!


🤖 Reviewed by codereviewbot.ai - Catch bugs before your team does.

@ecc-tools

ecc-tools Bot commented Aug 23, 2026

Copy link
Copy Markdown

Analyzing 200 commits...

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a93ae8fe-399b-49dd-88b2-b88717d329ee


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ecc-tools

ecc-tools Bot commented Aug 23, 2026

Copy link
Copy Markdown

Analysis Complete

Generated ECC bundle from 1 commits | Confidence: 50%

View Pull Request #2

Repository Profile
Attribute Value
Language C#
Framework Not detected
Commit Convention conventional
Test Directory separate
Changed Files (5)
Metric Value
Files changed 5
Additions 233
Deletions 6

Top hotspots

Path Status +/-
tests/RouterPlus.Core.Tests/RouterApiDeleteConnectionTests.cs added +99 / -0
src/RouterPlus.App/ViewModels/MainViewModel.cs modified +80 / -0
src/RouterPlus.App/MainWindow.xaml modified +39 / -6
src/RouterPlus.Infrastructure/Router/RouterApiClient.cs modified +11 / -0
src/RouterPlus.Infrastructure/Router/IRouterApiClient.cs modified +4 / -0

Top directories

Directory Files Total changes
tests/RouterPlus.Core.Tests 1 99
src/RouterPlus.App/ViewModels 1 80
src/RouterPlus.App 1 45
src/RouterPlus.Infrastructure/Router 2 15
Analysis Depth Readiness (commit-history, 7%)

ECC Tools uses this to decide whether recommendations should stay at commit-history/setup guidance or expand into CI, security, harness, reference-set, AI-routing, and team backlog work.

Area Status Evidence / Next Step
Commit history Partial 1 commits sampled
CI/CD signals Missing Add workflow files or CI troubleshooting evidence so ECC Tools can reason about pipeline setup.
Security evidence Missing Add AgentShield, audit, SARIF, SBOM, or security review evidence so recommendations can cover security posture.
Harness configuration Missing Add Claude, Codex, OpenCode, Zed, dmux, MCP, plugin, or cross-harness config evidence for harness-agnostic recommendations.
Reference/eval evidence Missing Add fixtures, golden traces, reference sets, or evaluator benchmarks so deeper recommendations have regression evidence.
AI routing and cost controls Missing Add model-routing, budget, usage, or cost-control files before relying on AI-heavy automation recommendations.
Team handoff and project tracking Missing Add roadmap, runbook, project, Linear, or follow-up tracking docs so generated work can land in a team queue.
Reference Set Readiness (0/7, 0%)
Area Status Evidence / Next Step
Deep analyzer corpus Missing Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison Missing Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus Missing Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus Missing Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility Missing Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence Missing Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence Missing Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.
Generated Instincts (6)
Domain Count
git 2
code-style 3
testing 1

After merging, import with:

/instinct-import .claude/homunculus/instincts/inherited/9router-plus-instincts.yaml

Files

  • .claude/ecc-tools.json
  • .claude/skills/9router-plus/SKILL.md
  • .agents/skills/9router-plus/SKILL.md
  • .agents/skills/9router-plus/agents/openai.yaml
  • .claude/identity.json
  • .codex/config.toml
  • .codex/AGENTS.md
  • .codex/agents/explorer.toml
  • .codex/agents/reviewer.toml
  • .codex/agents/docs-researcher.toml
  • .claude/homunculus/instincts/inherited/9router-plus-instincts.yaml

ECC Tools | Everything Claude Code

@hieuck
hieuck merged commit 644ed67 into main Aug 23, 2026
1 of 3 checks passed
@hieuck
hieuck deleted the feat/delete-connection branch August 23, 2026 13:59
hieuck added a commit that referenced this pull request Aug 23, 2026
feat: delete connection per profile with header icon buttons
hieuck added a commit that referenced this pull request Aug 31, 2026
feat: delete connection per profile with header icon buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant