Add support for JuiceSSH generated ed25519 keys#770
Merged
hierynomus merged 1 commit intoMar 7, 2022
Conversation
Reported from TeamAmaze/AmazeFileManager#2976, it was found the key uses aes-128-cbc which is currently not supported by sshj. This change adds support for it. To enable support for this, also eliminated hardcoding byte array size for key and IV, as a result of BCrypt.pbkdf().
TranceLove
force-pushed
the
bugfix/ed25519-encrypted-keys
branch
from
March 5, 2022 09:52
cc9c68b to
a90ef6e
Compare
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
============================================
+ Coverage 64.39% 64.47% +0.07%
- Complexity 1459 1461 +2
============================================
Files 211 211
Lines 8615 8617 +2
Branches 806 807 +1
============================================
+ Hits 5548 5556 +8
+ Misses 2643 2639 -4
+ Partials 424 422 -2
Continue to review full report at Codecov.
|
Owner
|
Thanks, changes look good. Consider it merged! |
hierynomus
approved these changes
Mar 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported from TeamAmaze/AmazeFileManager#2976, it was found the key uses
aes-128-cbcwhich is currently not supported by sshj. This change adds support for it.To enable support for this, also eliminated hardcoding byte array size for key and IV, as a result of
BCrypt.pbkdf().