Comprehensive support for publickey auth with certificates#702
Merged
hierynomus merged 7 commits intoJul 2, 2021
Conversation
…blickey auth with that keys.
hierynomus
approved these changes
Jul 2, 2021
hierynomus
left a comment
Owner
There was a problem hiding this comment.
@vladimirlagunov Wow, thanks! Looks good.
Owner
|
Ah wait, you missed |
Contributor
Author
|
By the way, I'm working on host key certificates support (i.e. |
Owner
|
Sure, will do, just let me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As for now, only RSA and DSA user keys in PEM format have been supported. This pull request also adds EcDSA and Ed25519 user key certificates support, and adds support of certificates for RFC4716 key format.
The pull request includes an integration test
KeyWithCertificateSpecfor all mentioned keys.