Skip to content

Comprehensive support for publickey auth with certificates#702

Merged
hierynomus merged 7 commits into
hierynomus:masterfrom
vladimirlagunov:user-key-certificates
Jul 2, 2021
Merged

Comprehensive support for publickey auth with certificates#702
hierynomus merged 7 commits into
hierynomus:masterfrom
vladimirlagunov:user-key-certificates

Conversation

@vladimirlagunov

Copy link
Copy Markdown
Contributor

As for now, only RSA and DSA user keys in PEM format have been supported. This pull request also adds EcDSA and Ed25519 user key certificates support, and adds support of certificates for RFC4716 key format.

The pull request includes an integration test KeyWithCertificateSpec for all mentioned keys.

@hierynomus hierynomus left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladimirlagunov Wow, thanks! Looks good.

@hierynomus

Copy link
Copy Markdown
Owner

Ah wait, you missed gradle licenseFormatTest ;)

@vladimirlagunov

Copy link
Copy Markdown
Contributor Author

By the way, I'm working on host key certificates support (i.e. @cert-authority in known_hosts files) right now. I have a working prototype, but it doesn't validate remote hosts properly yet. That code is based on this branch. So, if this code is merged, give me some time to add more changes before releasing the new version, please.

@hierynomus

Copy link
Copy Markdown
Owner

Sure, will do, just let me know!

@hierynomus
hierynomus merged commit ff4a477 into hierynomus:master Jul 2, 2021
@vladimirlagunov
vladimirlagunov deleted the user-key-certificates branch July 2, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants