Skip to content

Conversation

@tech0priyanshu
Copy link

@tech0priyanshu tech0priyanshu commented Sep 12, 2025

Description:

Add detailed usage examples for token airdrop and token airdrop cancel to improve developer clarity.

  • Add examples/token_airdrop.py with usage details
  • Add examples/token_airdrop_cancel.py with usage details

Related issue(s):

Fixes #372

Checklist

  • Documented (examples + README updated)

  • Tested (ran examples locally, added references in docs)

Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
@exploreriii
Copy link
Contributor

Hi thank you for this @tech0priyanshu. We require a log in the changelog please to describe your PR.
If its not in the contributing.md, please could you help by creating an issue?

Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the formatting and additions...
Watch out the recipient balance is not adding up
Also please check a couple other details

Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this example is all working yet

Key bits to check

  • whether association worked
  • whether airdrop output is correct

CHANGELOG.md Outdated
- consumeLargeData() function in StatefulContract
- example script for Token Airdrop
- added variables directly in the example script to reduce the need for users to supply extra environment variables.
- Added comprehensive example script for Token Airdrop (`token_airdrop.py`) that demonstrates:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to:
Added to the example script for Token Airdrop...
(as it existed before)
I'd suggest summarising the changes so its just one line. if that's not possible, make sure the bullets are indented so it is clear it is related to token airdrop change.

@exploreriii
Copy link
Contributor

Hi @tech0priyanshu just checking in on this, let us know if you need any help. Thank you

Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
…log.md

Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tech0priyanshu , there is a problem with your signing for these commits:

🔴 | 29c4b5f | Revise CHANGELOG.md for recent updates | No sign-off matches the author or committer
🔴 29c4b5f Revise CHANGELOG.md for recent updates No sign-off matches the author or committer

This is your most recent commit I think so maybe the easiest path is to soft revert your last commit and re-sign it

@exploreriii
Copy link
Contributor

Sorry, also, we have a new 0.1.5 update so please rebase with a changed section for the unreleased content

@tech0priyanshu tech0priyanshu force-pushed the feat/add-token-airdrop branch 3 times, most recently from 8c39a72 to 1b3eba4 Compare September 28, 2025 20:58
@exploreriii
Copy link
Contributor

Your last commit is still unverified, make sure you
git commit -S -s -m "chore: changelog update"
perhaps soft revert and try again

@tech0priyanshu tech0priyanshu force-pushed the feat/add-token-airdrop branch from e0c1595 to e989040 Compare October 5, 2025 20:16
Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
@tech0priyanshu tech0priyanshu force-pushed the feat/add-token-airdrop branch from e989040 to 7603fc6 Compare October 5, 2025 20:18
Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
@exploreriii
Copy link
Contributor

Hi @tech0priyanshu
Could you please confirm if you are still working on this?
We will be releasing 0.1.6 which will require another rebase and a changelog update from 0.1.5 to 0.1.6
Many thanks

@tech0priyanshu
Copy link
Author

tech0priyanshu commented Oct 17, 2025 via email

@exploreriii
Copy link
Contributor

No problem take the time you need.

…thon into feat/add-token-airdrop

Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
@tech0priyanshu
Copy link
Author

tech0priyanshu commented Oct 18, 2025 via email

@exploreriii
Copy link
Contributor

Got it, next on my review list

Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tech0priyanshu
Thanks for all this - it is looking robust and a lot of hard work has gone into it
However, as there is a lot more content and logic, would it be possible to split this up into more modular functions which are then called from the main?

For example:

def token_airdrop
should just literally airdrop

def token_airdrop_confirm
could do the checks etc

then in main
token_airdrop()
token_airdrop_confirm()

The reason I mention this is if users want to copy the examples and use them in their own code, they might not need all the logic - they might just want to just perform the airdrop, or just to associate, etc.

I know it will involve more work, what do you think?

@exploreriii
Copy link
Contributor

@tech0priyanshu just checking if you need anything

@tech0priyanshu
Copy link
Author

tech0priyanshu commented Oct 28, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add detail to examples/token_airdrop and examples/token_airdrop_cancel

3 participants