-
Notifications
You must be signed in to change notification settings - Fork 86
feat: add detail to token_airdrop and token_airdrop_cancel #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add detail to token_airdrop and token_airdrop_cancel #376
Conversation
Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
|
Hi thank you for this @tech0priyanshu. We require a log in the changelog please to describe your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the formatting and additions...
Watch out the recipient balance is not adding up
Also please check a couple other details
Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
38ecc4e to
3dddb74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this example is all working yet
Key bits to check
- whether association worked
- whether airdrop output is correct
CHANGELOG.md
Outdated
| - consumeLargeData() function in StatefulContract | ||
| - example script for Token Airdrop | ||
| - added variables directly in the example script to reduce the need for users to supply extra environment variables. | ||
| - Added comprehensive example script for Token Airdrop (`token_airdrop.py`) that demonstrates: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to:
Added to the example script for Token Airdrop...
(as it existed before)
I'd suggest summarising the changes so its just one line. if that's not possible, make sure the bullets are indented so it is clear it is related to token airdrop change.
|
Hi @tech0priyanshu just checking in on this, let us know if you need any help. Thank you |
…thon into feat/add-token-airdrop
Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
…anshu/hiero-sdk-python into feat/add-token-airdrop
…log.md Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
dc178d8 to
29c4b5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tech0priyanshu , there is a problem with your signing for these commits:
🔴 | 29c4b5f | Revise CHANGELOG.md for recent updates | No sign-off matches the author or committer
🔴 29c4b5f Revise CHANGELOG.md for recent updates No sign-off matches the author or committer
This is your most recent commit I think so maybe the easiest path is to soft revert your last commit and re-sign it
|
Sorry, also, we have a new 0.1.5 update so please rebase with a changed section for the unreleased content |
8c39a72 to
1b3eba4
Compare
|
Your last commit is still unverified, make sure you |
e0c1595 to
e989040
Compare
Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
e989040 to
7603fc6
Compare
Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
|
Hi @tech0priyanshu |
|
Hi @explorerII Yes, I will make the necessary changes by tomorrow. I
apologize for the delay; I was occupied with my exams.
…On Fri, 17 Oct 2025 at 03:42, exploreriii ***@***.***> wrote:
*exploreriii* left a comment (hiero-ledger/hiero-sdk-python#376)
<#376 (comment)>
Hi @tech0priyanshu <https://github.com/tech0priyanshu>
Could you please confirm if you are still working on this?
We will be releasing 0.1.6 which will require another rebase and a
changelog update from 0.1.5 to 0.1.6
Many thanks
—
Reply to this email directly, view it on GitHub
<#376 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIHS6UN5UUM2EY5B4Q4DUC33YAJ5LAVCNFSM6AAAAACGK2HU2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMJTGAZDMNBSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
No problem take the time you need. |
…thon into feat/add-token-airdrop
…thon into feat/add-token-airdrop Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
…anshu/hiero-sdk-python into feat/add-token-airdrop
|
Hi @exploreriii and @nadineloepfe,I have now implemented all the requested
changes.
…On Fri, 17 Oct 2025 at 19:22, exploreriii ***@***.***> wrote:
*exploreriii* left a comment (hiero-ledger/hiero-sdk-python#376)
<#376 (comment)>
No problem take the time you need.
—
Reply to this email directly, view it on GitHub
<#376 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIHS6ULH7XMDYBHTC76N2DT3YDYALAVCNFSM6AAAAACGK2HU2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMJVG4YTAMRVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Got it, next on my review list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tech0priyanshu
Thanks for all this - it is looking robust and a lot of hard work has gone into it
However, as there is a lot more content and logic, would it be possible to split this up into more modular functions which are then called from the main?
For example:
def token_airdrop
should just literally airdrop
def token_airdrop_confirm
could do the checks etc
then in main
token_airdrop()
token_airdrop_confirm()
The reason I mention this is if users want to copy the examples and use them in their own code, they might not need all the logic - they might just want to just perform the airdrop, or just to associate, etc.
I know it will involve more work, what do you think?
|
@tech0priyanshu just checking if you need anything |
|
Hey @exploreriii Sorry for the delay in fixes — I had some important work
that required me to travel out of town. I’ll complete the fixes and sync
the update by *November 9*.
Apologies for not posting earlier.
…On Tue, 28 Oct 2025, 19:26 exploreriii, ***@***.***> wrote:
*exploreriii* left a comment (hiero-ledger/hiero-sdk-python#376)
<#376 (comment)>
@tech0priyanshu <https://github.com/tech0priyanshu> just checking if you
need anything
—
Reply to this email directly, view it on GitHub
<#376 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIHS6UNYMFGB2SKGEFX4WC33Z5YZRAVCNFSM6AAAAACGK2HU2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINJWGYYDIOJXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Description:
Add detailed usage examples for token airdrop and token airdrop cancel to improve developer clarity.
Related issue(s):
Fixes #372
Checklist
Documented (examples + README updated)
Tested (ran examples locally, added references in docs)