feat: add a tx gasPrice Buffer to reduce INSUFFICIENT_TX_FEE cases #2692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
natanasow
requested review from
a team,
AlfredoG87,
ebadiere and
lukelee-sl
as code owners
Nana-EC
reviewed
Jul 10, 2024
Contributor
Nana-EC
left a comment
Nana-EC
left a comment
There was a problem hiding this comment.
Looking good.
One recommendation for coverage
Signed-off-by: nikolay <n.atanasow94@gmail.com>
natanasow
requested review from
Ivo-Yankov,
Nana-EC,
acuarica,
georgi-l95,
konstantinabl,
quiet-node and
victor-yanev
quiet-node
reviewed
Jul 11, 2024
Nana-EC
previously approved these changes
Jul 11, 2024
Contributor
Nana-EC
left a comment
Nana-EC
left a comment
There was a problem hiding this comment.
Good change.
None blocking suggestions that can be done in future PRs
- Move the
addPercentageBufferToGasPrice()to a different util class (new one if necessary).formatter.tsdoesn't seem like the right location - Adopt the README suggestion
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
|
natanasow
deleted the
2674-add-a-tx-gasprice-buffer-to-reduce-insufficient-tx-fee-cases
branch
ebadiere
pushed a commit
that referenced
this pull request
Aug 1, 2024
…2692) * chore: add buffer Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: edit tests in order to fix code duplication warning Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: move the calculations to formatter.ts Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: fix readme Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: add utils class Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: fix sonarcloud issue Signed-off-by: nikolay <n.atanasow94@gmail.com> --------- Signed-off-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Occasionally users observe an
INSUFFICIENT_TX_FEE.This may be for insufficient gasLimit supply but occasionally it's due to a change in the exchange rate that results in the converted hbar value of the gasLimit not being sufficient.
This is hard to determine as it changes infrequently but also due to caching optimizations the relay may miss this.
Solution:
Add a configureable setting
GAS_PRICE_PERCENTAGE_BUFFERthat adds a percentage on top of the calculated network gasPrice.Note: This may be a band-aid option to improve user experience while exploring other longer-term options.
Related issue(s):
Fixes #2674
Notes for reviewer:
Checklist