fix: Added HBar rate limiter to createFile #2634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ebadiere <ebadiere@gmail.com>
Nana-EC
requested changes
Jun 28, 2024
Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Nana-EC
previously approved these changes
Jun 28, 2024
Contributor
Nana-EC
left a comment
Nana-EC
left a comment
There was a problem hiding this comment.
Unblocking but please correct the logging item.
The rest can be done in follow up
Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
quiet-node
reviewed
Jun 28, 2024
…://github.com/hashgraph/hedera-json-rpc-relay into 2631-add-hbar-rateLimiter-to-createFile-added Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
|
quiet-node
approved these changes
Jun 28, 2024
quiet-node
added a commit
that referenced
this pull request
Jun 29, 2024
* fix: Added HBar rate limiter to createFile Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Build fix and applied feedback. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: removed duplicated query & added return statement Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * Update packages/relay/src/lib/clients/sdkClient.ts Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> * fix: removed unused variable Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: Applied feedback Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Fixed scope. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com>
2 tasks
Nana-EC
added a commit
that referenced
this pull request
Jun 29, 2024
* fix: Added HBar rate limiter to createFile * fix: Build fix and applied feedback. * fix: removed duplicated query & added return statement * Update packages/relay/src/lib/clients/sdkClient.ts * fix: removed unused variable * fix: Applied feedback * fix: Fixed scope. --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Eric Badiere <ebadiere@gmail.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added HBar rate limiting to sdkClient.createFile.
Related issue(s):
Fixes #2631