Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add HistoryService handlers #17535

Merged
merged 9 commits into from
Jan 27, 2025
Merged

Conversation

tinker-michaelj
Copy link
Contributor

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj added this to the v0.59 milestone Jan 24, 2025
@tinker-michaelj tinker-michaelj self-assigned this Jan 24, 2025
Copy link

codacy-production bot commented Jan 24, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 86.90%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (adad3c1) 97881 71328 72.87%
Head commit (47f8933) 98150 (+269) 71553 (+225) 72.90% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17535) 290 252 86.90%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 85.17241% with 43 lines in your changes missing coverage. Please review.

Project coverage is 68.98%. Comparing base (adad3c1) to head (47f8933).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...-app/src/main/java/com/hedera/node/app/Hedera.java 29.41% 12 Missing ⚠️
...a/node/app/history/impl/ProofKeysAccessorImpl.java 0.00% 8 Missing ⚠️
...era/node/app/history/handlers/HistoryHandlers.java 0.00% 5 Missing ⚠️
.../src/main/java/com/hedera/hapi/util/HapiUtils.java 0.00% 3 Missing ⚠️
.../main/java/com/hedera/node/app/spi/AppContext.java 91.89% 3 Missing ⚠️
...rc/main/java/com/hedera/node/app/ServicesMain.java 0.00% 3 Missing ⚠️
...om/hedera/node/app/history/impl/HistoryModule.java 0.00% 2 Missing ⚠️
...dera/node/app/history/impl/HistoryServiceImpl.java 91.30% 0 Missing and 2 partials ⚠️
.../com/hedera/node/app/hints/ReadableHintsStore.java 50.00% 0 Missing and 1 partial ⚠️
.../hedera/node/app/history/ReadableHistoryStore.java 50.00% 0 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17535      +/-   ##
============================================
+ Coverage     68.94%   68.98%   +0.03%     
- Complexity    22713    22781      +68     
============================================
  Files          2619     2630      +11     
  Lines         98098    98367     +269     
  Branches      10161    10182      +21     
============================================
+ Hits          67636    67856     +220     
- Misses        26619    26663      +44     
- Partials       3843     3848       +5     
Files with missing lines Coverage Δ
...om/hedera/node/app/blocks/impl/BlockImplUtils.java 80.62% <100.00%> (ø)
...a/node/app/blocks/impl/BlockStreamManagerImpl.java 94.53% <ø> (ø)
...m/hedera/node/app/hints/impl/HintsServiceImpl.java 100.00% <100.00%> (ø)
...ra/node/app/hints/impl/ReadableHintsStoreImpl.java 92.50% <100.00%> (+0.19%) ⬆️
...ra/node/app/hints/impl/WritableHintsStoreImpl.java 97.19% <100.00%> (ø)
...hedera/node/app/hints/schemas/V059HintsSchema.java 100.00% <100.00%> (ø)
...va/com/hedera/node/app/history/HistoryService.java 100.00% <ø> (ø)
...ry/handlers/HistoryProofKeyPublicationHandler.java 100.00% <100.00%> (ø)
...history/handlers/HistoryProofSignatureHandler.java 100.00% <100.00%> (ø)
.../app/history/handlers/HistoryProofVoteHandler.java 100.00% <100.00%> (ø)
... and 20 more

... and 8 files with indirect coverage changes

Impacted file tree graph

andrewb1269hg
andrewb1269hg previously approved these changes Jan 24, 2025
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve file hedera-node/hedera-app-spi/build.gradle.kts

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
andrewb1269hg
andrewb1269hg previously approved these changes Jan 25, 2025
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve file hedera-node/hedera-app-spi/build.gradle.kts

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link
Contributor

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @tinker-michaelj

Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tinker-michaelj

Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove.

@tinker-michaelj tinker-michaelj merged commit b44fa0a into main Jan 27, 2025
45 of 46 checks passed
@tinker-michaelj tinker-michaelj deleted the 17445-history-handlers branch January 27, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement HistoryService handlers
4 participants