Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 17501 Fixed PlatformTestingTool initialization. #17531

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

imalygin
Copy link
Contributor

Description:

This PR fixes PlatformTestingTool tests

Related issue(s):

Fixes #17501

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
@imalygin imalygin requested a review from a team as a code owner January 24, 2025 04:22
@imalygin imalygin self-assigned this Jan 24, 2025
@imalygin imalygin added this to the v0.59 milestone Jan 24, 2025
@imalygin imalygin changed the title fix: 17501 Fixed PlatformTestingTool initialization fix: 17501 Fixed PlatformTestingTool initialization. Jan 24, 2025
poulok
poulok previously approved these changes Jan 24, 2025
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.04% (target: -1.00%) 27.78%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ee24004) 98068 71447 72.85%
Head commit (9b7a483) 98007 (-61) 71444 (-3) 72.90% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17531) 18 5 27.78%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.

Project coverage is 68.98%. Comparing base (ee24004) to head (9b7a483).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...wirlds/demo/platform/PlatformTestingToolState.java 0.00% 7 Missing ⚠️
...swirlds/demo/platform/PlatformTestingToolMain.java 57.14% 3 Missing ⚠️
...main/java/com/swirlds/demo/platform/AppClient.java 0.00% 2 Missing ⚠️
.../com/swirlds/demo/platform/PttTransactionPool.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17531      +/-   ##
============================================
+ Coverage     68.94%   68.98%   +0.04%     
+ Complexity    22757    22754       -3     
============================================
  Files          2619     2619              
  Lines         98285    98233      -52     
  Branches      10185    10182       -3     
============================================
+ Hits          67761    67767       +6     
+ Misses        26687    26629      -58     
  Partials       3837     3837              
Files with missing lines Coverage Δ
...o/platform/PlatformTestingToolStateLifecycles.java 35.19% <100.00%> (+1.74%) ⬆️
.../com/swirlds/demo/platform/PttTransactionPool.java 22.04% <0.00%> (+0.11%) ⬆️
...main/java/com/swirlds/demo/platform/AppClient.java 0.00% <0.00%> (ø)
...swirlds/demo/platform/PlatformTestingToolMain.java 41.00% <57.14%> (+0.09%) ⬆️
...wirlds/demo/platform/PlatformTestingToolState.java 10.12% <0.00%> (+0.48%) ⬆️

... and 10 files with indirect coverage changes

Impacted file tree graph

Copy link
Contributor

@anthony-swirldslabs anthony-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imalygin imalygin merged commit ef25861 into main Jan 24, 2025
44 of 46 checks passed
@imalygin imalygin deleted the 17505-ptt-npe branch January 24, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JRS: The address books are not equal as Roster
3 participants