Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix JRS tests failing because of PCES #17508

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

lpetrovic05
Copy link
Contributor

@lpetrovic05 lpetrovic05 commented Jan 23, 2025

quick fix for #17500

In this PR I unsuppressed these exceptions and now they are breaking JRS tests. This is a quick fix to get the tests running while the issue is investigated more.

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05 lpetrovic05 self-assigned this Jan 23, 2025
@lpetrovic05 lpetrovic05 added this to the v0.59 milestone Jan 23, 2025
@lpetrovic05 lpetrovic05 added Audit Issues resulting from a code or process audit and removed Audit Issues resulting from a code or process audit labels Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.96%. Comparing base (053a5c1) to head (cfdcab5).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17508      +/-   ##
============================================
- Coverage     68.96%   68.96%   -0.01%     
- Complexity    22765    22767       +2     
============================================
  Files          2619     2619              
  Lines         98283    98282       -1     
  Branches      10185    10185              
============================================
- Hits          67780    67779       -1     
- Misses        26674    26675       +1     
+ Partials       3829     3828       -1     
Files with missing lines Coverage Δ
.../platform/event/preconsensus/PcesFileIterator.java 86.04% <ø> (-0.32%) ⬇️

... and 9 files with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (053a5c1) 98066 71458 72.87%
Head commit (cfdcab5) 98065 (-1) 71456 (-2) 72.87% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17508) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@lpetrovic05 lpetrovic05 marked this pull request as ready for review January 23, 2025 14:55
@lpetrovic05 lpetrovic05 requested review from a team as code owners January 23, 2025 14:55
@lpetrovic05 lpetrovic05 merged commit 4da0822 into main Jan 23, 2025
74 of 76 checks passed
@lpetrovic05 lpetrovic05 deleted the 17500-M-suppress-PCES-file-read-exception branch January 23, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants