Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add HistoryService schemas and stores #17439

Merged
merged 13 commits into from
Jan 22, 2025

Conversation

tinker-michaelj
Copy link
Contributor

Neeharika-Sompalli and others added 9 commits January 16, 2025 15:41
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 82.30769% with 46 lines in your changes missing coverage. Please review.

Project coverage is 68.99%. Comparing base (c5e7dc1) to head (be8a2f3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...dera/node/app/history/impl/HistoryLibraryImpl.java 4.34% 22 Missing ⚠️
...ra/node/app/blocks/impl/KVStateChangeListener.java 0.00% 4 Missing ⚠️
...node/app/history/impl/HistoryLibraryCodecImpl.java 70.00% 3 Missing ⚠️
...ode/app/history/impl/ReadableHistoryStoreImpl.java 93.33% 0 Missing and 3 partials ⚠️
...rc/main/java/com/hedera/node/app/ServicesMain.java 0.00% 2 Missing ⚠️
...e/app/blocks/impl/BoundaryStateChangeListener.java 0.00% 2 Missing ⚠️
...ode/app/history/impl/WritableHistoryStoreImpl.java 98.07% 1 Missing and 1 partial ⚠️
...ra/node/app/history/schemas/V059HistorySchema.java 92.30% 1 Missing and 1 partial ⚠️
...java/com/hedera/node/app/roster/ActiveRosters.java 77.77% 1 Missing and 1 partial ⚠️
...om/hedera/node/app/blocks/impl/BlockImplUtils.java 90.00% 0 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17439      +/-   ##
============================================
- Coverage     69.01%   68.99%   -0.03%     
- Complexity    22724    22770      +46     
============================================
  Files          2615     2619       +4     
  Lines         98026    98268     +242     
  Branches      10162    10184      +22     
============================================
+ Hits          67649    67796     +147     
- Misses        26559    26644      +85     
- Partials       3818     3828      +10     
Files with missing lines Coverage Δ
...va/com/hedera/node/app/history/HistoryService.java 100.00% <100.00%> (ø)
.../hedera/node/app/history/ReadableHistoryStore.java 100.00% <100.00%> (ø)
...in/java/com/hedera/node/config/data/TssConfig.java 100.00% <ø> (ø)
...om/hedera/node/app/blocks/impl/BlockImplUtils.java 80.62% <90.00%> (+0.45%) ⬆️
...om/hedera/node/app/history/impl/HistoryModule.java 0.00% <0.00%> (ø)
...dera/node/app/history/impl/HistoryServiceImpl.java 75.00% <91.66%> (-25.00%) ⬇️
...dera/node/app/workflows/handle/HandleWorkflow.java 64.62% <66.66%> (+0.47%) ⬆️
...rc/main/java/com/hedera/node/app/ServicesMain.java 26.66% <0.00%> (-0.37%) ⬇️
...e/app/blocks/impl/BoundaryStateChangeListener.java 61.95% <0.00%> (-1.38%) ⬇️
...ode/app/history/impl/WritableHistoryStoreImpl.java 98.09% <98.07%> (+98.09%) ⬆️
... and 6 more

... and 20 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Jan 18, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) 85.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c5e7dc1) 97809 71316 72.91%
Head commit (be8a2f3) 98051 (+242) 71473 (+157) 72.89% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17439) 260 221 85.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj added this to the v0.59 milestone Jan 18, 2025
@tinker-michaelj tinker-michaelj self-assigned this Jan 18, 2025
Base automatically changed from 17316-D-add-entity-counts to main January 21, 2025 19:08
@Neeharika-Sompalli Neeharika-Sompalli requested a review from a team as a code owner January 21, 2025 19:08
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link
Contributor

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tyvm @tinker-michaelj

@tinker-michaelj tinker-michaelj merged commit bbdc054 into main Jan 22, 2025
45 of 46 checks passed
@tinker-michaelj tinker-michaelj deleted the 17229-history-protos-and-schema branch January 22, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add schema and readable/writable stores for HistoryService
2 participants