-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: HIP-756 Rename Schedule Get Info Smart Contracts Query Functions #17429
Conversation
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you very much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't like the duplication of [I]HederaScheduleService.sol
- can that be fixed?
...test-clients/src/main/resources/contract/contracts/GetScheduleInfo/HederaScheduleService.sol
Outdated
Show resolved
Hide resolved
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17429 +/- ##
============================================
- Coverage 68.75% 68.74% -0.01%
+ Complexity 22593 22592 -1
============================================
Files 2610 2610
Lines 97202 97208 +6
Branches 10129 10129
============================================
- Hits 66827 66825 -2
- Misses 26560 26567 +7
- Partials 3815 3816 +1
|
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Rename the query functions in HIP-756
from
getScheduledFungibleTokenCreateTransaction
andgetScheduledNonFungibleTokenCreateTransaction
to
getScheduledCreateFungibleTokenInfo
andgetScheduledCreateNonFungibleTokenInfo
Updating design doc, HSCS selector, bdd tests and solidity references
Related issue(s):
Fixes #17428
Notes for reviewer:
Checklist