Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: HIP-756 Rename Schedule Get Info Smart Contracts Query Functions #17429

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

stoyanov-st
Copy link
Contributor

Description:
Rename the query functions in HIP-756
from getScheduledFungibleTokenCreateTransaction and getScheduledNonFungibleTokenCreateTransaction
to getScheduledCreateFungibleTokenInfo and getScheduledCreateNonFungibleTokenInfo

Updating design doc, HSCS selector, bdd tests and solidity references

Related issue(s):

Fixes #17428

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
@stoyanov-st stoyanov-st added this to the v0.59 milestone Jan 17, 2025
@stoyanov-st stoyanov-st self-assigned this Jan 17, 2025
@stoyanov-st stoyanov-st requested review from a team and tinker-michaelj as code owners January 17, 2025 16:37
lukelee-sl
lukelee-sl previously approved these changes Jan 17, 2025
Copy link
Contributor

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much!

Copy link
Contributor

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't like the duplication of [I]HederaScheduleService.sol - can that be fixed?

Copy link

codacy-production bot commented Jan 17, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d779434) 96985 70491 72.68%
Head commit (97dc906) 96991 (+6) 70490 (-1) 72.68% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17429) 5 5 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (d779434) to head (97dc906).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17429      +/-   ##
============================================
- Coverage     68.75%   68.74%   -0.01%     
+ Complexity    22593    22592       -1     
============================================
  Files          2610     2610              
  Lines         97202    97208       +6     
  Branches      10129    10129              
============================================
- Hits          66827    66825       -2     
- Misses        26560    26567       +7     
- Partials       3815     3816       +1     
Files with missing lines Coverage Δ
...duledinfo/GetScheduledFungibleTokenCreateCall.java 95.65% <ø> (ø)
...s/getscheduledinfo/GetScheduledInfoTranslator.java 100.00% <100.00%> (ø)
...edinfo/GetScheduledNonFungibleTokenCreateCall.java 95.65% <ø> (ø)

... and 5 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Copy link
Contributor

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukelee-sl lukelee-sl merged commit ad099ae into main Jan 18, 2025
52 checks passed
@lukelee-sl lukelee-sl deleted the hip-756-rename-query-functions branch January 18, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HIP-756] Rename query functions
3 participants