-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add solidity files defining the hedera schedule service #17422
Conversation
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...lients/src/main/resources/contract/contracts/HederaScheduleService/HederaScheduleService.sol
Show resolved
Hide resolved
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but wondering about the method name.
...lients/src/main/resources/contract/contracts/HederaScheduleService/HederaScheduleService.sol
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17422 +/- ##
=========================================
Coverage 68.74% 68.74%
- Complexity 22587 22589 +2
=========================================
Files 2610 2610
Lines 97202 97202
Branches 10129 10129
=========================================
+ Hits 66820 66824 +4
+ Misses 26562 26560 -2
+ Partials 3820 3818 -2 |
Description:
Define the Hedera Schedule Service system contract with these solidity files