Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add solidity files defining the hedera schedule service #17422

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

lukelee-sl
Copy link
Contributor

@lukelee-sl lukelee-sl commented Jan 17, 2025

Description:
Define the Hedera Schedule Service system contract with these solidity files

Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
@lukelee-sl lukelee-sl added this to the v0.59 milestone Jan 17, 2025
@lukelee-sl lukelee-sl self-assigned this Jan 17, 2025
@lukelee-sl lukelee-sl requested review from a team as code owners January 17, 2025 00:02
@lukelee-sl lukelee-sl requested a review from mhess-swl January 17, 2025 00:02
Copy link
Contributor

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codacy-production bot commented Jan 17, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a37e5a4) 96985 70489 72.68%
Head commit (72e3d4a) 96985 (+0) 70491 (+2) 72.68% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17422) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but wondering about the method name.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (a37e5a4) to head (72e3d4a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #17422   +/-   ##
=========================================
  Coverage     68.74%   68.74%           
- Complexity    22587    22589    +2     
=========================================
  Files          2610     2610           
  Lines         97202    97202           
  Branches      10129    10129           
=========================================
+ Hits          66820    66824    +4     
+ Misses        26562    26560    -2     
+ Partials       3820     3818    -2     

see 2 files with indirect coverage changes

Impacted file tree graph

@lukelee-sl lukelee-sl merged commit d801950 into main Jan 17, 2025
64 checks passed
@lukelee-sl lukelee-sl deleted the hedera-schedule-service-artifacts branch January 17, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants