Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move long term tests to repeatable #17313

Merged
merged 3 commits into from
Jan 14, 2025
Merged

fix: move long term tests to repeatable #17313

merged 3 commits into from
Jan 14, 2025

Conversation

ibankov
Copy link
Contributor

@ibankov ibankov commented Jan 10, 2025

Description:
Currently the LongTermSchedules test ported from mono are flaky and cause CI pipeline failures, moving them to Repeatable tests so they no longer rely on timing but instead use virtual time.

Related issue(s):

Fixes #
#17287
Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: ibankov <ivan.bankov@limechain.tech>
@ibankov ibankov self-assigned this Jan 10, 2025
@ibankov ibankov requested review from a team as code owners January 10, 2025 13:02
@ibankov ibankov requested a review from kimbor January 10, 2025 13:02
@ibankov ibankov added this to the v0.59 milestone Jan 10, 2025
@ibankov ibankov linked an issue Jan 10, 2025 that may be closed by this pull request
@ibankov ibankov changed the title move long term tests to repeatable fix: move long term tests to repeatable Jan 10, 2025
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Copy link

codacy-production bot commented Jan 10, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.05% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (45f108d) 96164 68485 71.22%
Head commit (3e8e67f) 96341 (+177) 68661 (+176) 71.27% (+0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17313) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.43%. Comparing base (45f108d) to head (3e8e67f).
Report is 19 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17313      +/-   ##
============================================
+ Coverage     67.36%   67.43%   +0.07%     
- Complexity    22041    22110      +69     
============================================
  Files          2585     2588       +3     
  Lines         96381    96626     +245     
  Branches      10069    10094      +25     
============================================
+ Hits          64923    65160     +237     
- Misses        27744    27745       +1     
- Partials       3714     3721       +7     

see 44 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: ibankov <ivan.bankov@limechain.tech>
@povolev15
Copy link
Contributor

@ibankov TY. LGTM

@ibankov ibankov merged commit 6dae710 into main Jan 14, 2025
45 of 46 checks passed
@ibankov ibankov deleted the long-term-to-repetable branch January 14, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move LongTermSchedules tests ported from mono to RepeatableTests
2 participants