Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Clean up Node: Build Application workflow calls #17310

Merged

Conversation

mishomihov00
Copy link
Contributor

Description:

Clean up Node: Build Application workflow calls

Related issue(s):

Fixes #17233

Notes for reviewer:

This is PR containing just a suggestion for changes and can be closed at any time.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Mihail Mihov <mihail.mihov@limechain.tech>
Signed-off-by: Mihail Mihov <mihail.mihov@limechain.tech>
@mishomihov00 mishomihov00 added this to the v0.59 milestone Jan 10, 2025
@mishomihov00 mishomihov00 self-assigned this Jan 10, 2025
@mishomihov00 mishomihov00 requested review from a team as code owners January 10, 2025 08:28
@mishomihov00 mishomihov00 linked an issue Jan 10, 2025 that may be closed by this pull request
Copy link

codacy-production bot commented Jan 10, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (45f108d) 96164 68485 71.22%
Head commit (3f583da) 96164 (+0) 68485 (+0) 71.22% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17310) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.36%. Comparing base (45f108d) to head (3f583da).
Report is 30 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #17310   +/-   ##
=========================================
  Coverage     67.36%   67.36%           
  Complexity    22041    22041           
=========================================
  Files          2585     2585           
  Lines         96381    96381           
  Branches      10069    10069           
=========================================
  Hits          64923    64923           
  Misses        27744    27744           
  Partials       3714     3714           

Impacted file tree graph

Signed-off-by: Mihail Mihov <mihail.mihov@limechain.tech>
@mishomihov00 mishomihov00 merged commit 30ae2c8 into main Jan 15, 2025
46 checks passed
@mishomihov00 mishomihov00 deleted the 17233-clean-up-calls-to-node-flow-build-applicationyaml branch January 15, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up calls to node-flow-build-application.yaml
2 participants