chore: restore ServicesMainTest.java

hedera-node/hedera-app/src/main/java/com/hedera/node/app/ServicesMain.java

@@ -227,6 +227,9 @@ public static void main(final String... args) throws Exception {
                     EXCEPTION.getMarker(),
                     "Multiple nodes were supplied via the command line. Only one node can be started per java process.");
             exitSystem(NODE_ADDRESS_MISMATCH);
+            // the following throw is not reachable in production,
+            // but reachable in testing with static mocked system exit calls.
+            throw new ConfigurationException();
         }
         final var platformConfig = buildPlatformConfig();
         // Determine which nodes were _requested_ to run from the command line
@@ -410,12 +413,14 @@ private static NodeId ensureSingleNode(@NonNull final List<NodeId> nodesToRun) {
         if (nodesToRun.isEmpty()) {
             final String errorMessage = "No nodes are configured to run locally.";
             logger.error(STARTUP.getMarker(), errorMessage);
+            exitSystem(NODE_ADDRESS_MISMATCH, errorMessage);
             throw new ConfigurationException(errorMessage);
         }
 
         if (nodesToRun.size() > 1) {
             final String errorMessage = "Multiple nodes are configured to run locally.";
             logger.error(EXCEPTION.getMarker(), errorMessage);
+            exitSystem(NODE_ADDRESS_MISMATCH, errorMessage);
             throw new ConfigurationException(errorMessage);
         }
         return nodesToRun.getFirst();

hedera-node/hedera-app/src/test/java/com/hedera/node/app/ServicesMainTest.java

@@ -0,0 +1,131 @@
+/*
+ * Copyright (C) 2021-2025 Hedera Hashgraph, LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.hedera.node.app;
+
+import static com.swirlds.platform.system.SystemExitCode.NODE_ADDRESS_MISMATCH;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.BDDMockito.given;
+import static org.mockito.Mock.Strictness.LENIENT;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.mockStatic;
+import static org.mockito.Mockito.when;
+
+import com.hedera.hapi.node.base.SemanticVersion;
+import com.hedera.node.app.version.ServicesSoftwareVersion;
+import com.swirlds.metrics.api.Metrics;
+import com.swirlds.platform.config.legacy.ConfigurationException;
+import com.swirlds.platform.config.legacy.LegacyConfigProperties;
+import com.swirlds.platform.config.legacy.LegacyConfigPropertiesLoader;
+import com.swirlds.platform.state.PlatformMerkleStateRoot;
+import com.swirlds.platform.system.SystemExitUtils;
+import com.swirlds.platform.system.address.AddressBook;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Mock;
+import org.mockito.MockedStatic;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+@ExtendWith(MockitoExtension.class)
+final class ServicesMainTest {
+    private static final MockedStatic<LegacyConfigPropertiesLoader> legacyConfigPropertiesLoaderMockedStatic =
+            mockStatic(LegacyConfigPropertiesLoader.class);
+
+    @Mock(strictness = LENIENT)
+    private LegacyConfigProperties legacyConfigProperties = mock(LegacyConfigProperties.class);
+
+    @Mock(strictness = LENIENT)
+    private Metrics metrics;
+
+    @Mock(strictness = LENIENT)
+    private Hedera hedera;
+
+    @Mock
+    private PlatformMerkleStateRoot merkleStateRoot;
+
+    private final ServicesMain subject = new ServicesMain();
+
+    // no local nodes specified, no environment nodes specified
+    @Test
+    void throwsExceptionOnNoNodesToRun() {
+        withBadCommandLineArgs();
+        String[] args = {};
+        try (MockedStatic<SystemExitUtils> systemExitUtilsMockedStatic = mockStatic(SystemExitUtils.class)) {
+            assertThatThrownBy(() -> ServicesMain.main(args)).isInstanceOf(ConfigurationException.class);
+            systemExitUtilsMockedStatic.verify(
+                    () -> SystemExitUtils.exitSystem(eq(NODE_ADDRESS_MISMATCH), anyString()));
+        }
+    }
+
+    // local node specified which does not match the address book
+    @Test
+    void hardExitOnNonMatchingNodeId() {
+        withBadCommandLineArgs();
+        String[] args = {"-local", "1234"}; // 1234 does not match anything in address book
+
+        try (MockedStatic<SystemExitUtils> systemExitUtilsMockedStatic = mockStatic(SystemExitUtils.class)) {
+            assertThatThrownBy(() -> ServicesMain.main(args)).isInstanceOf(ConfigurationException.class);
+            systemExitUtilsMockedStatic.verify(
+                    () -> SystemExitUtils.exitSystem(eq(NODE_ADDRESS_MISMATCH), anyString()));
+        }
+    }
+
+    // more than one local node specified on the commandline
+    @Test
+    void hardExitOnTooManyCliNodes() {
+        withBadCommandLineArgs();
+        String[] args = {"-local", "1", "2"}; // both "1" and "2" match entries in address book
+
+        try (MockedStatic<SystemExitUtils> systemExitUtilsMockedStatic = mockStatic(SystemExitUtils.class)) {
+            assertThatThrownBy(() -> ServicesMain.main(args)).isInstanceOf(ConfigurationException.class);
+            systemExitUtilsMockedStatic.verify(() -> SystemExitUtils.exitSystem(NODE_ADDRESS_MISMATCH));
+        }
+    }
+
+    @Test
+    void delegatesSoftwareVersion() {
+        ServicesMain.initGlobal(hedera, metrics);
+        final var mockVersion = new ServicesSoftwareVersion(SemanticVersion.DEFAULT);
+        given(hedera.getSoftwareVersion()).willReturn(mockVersion);
+        assertSame(mockVersion, subject.getSoftwareVersion());
+    }
+
+    @Test
+    void noopsAsExpected() {
+        ServicesMain.initGlobal(hedera, metrics);
+        assertDoesNotThrow(subject::run);
+    }
+
+    @Test
+    void createsNewMerkleStateRoot() {
+        ServicesMain.initGlobal(hedera, metrics);
+        given(hedera.newMerkleStateRoot()).willReturn(merkleStateRoot);
+        assertSame(merkleStateRoot, subject.newMerkleStateRoot());
+    }
+
+    private void withBadCommandLineArgs() {
+        legacyConfigPropertiesLoaderMockedStatic
+                .when(() -> LegacyConfigPropertiesLoader.loadConfigFile(any()))
+                .thenReturn(legacyConfigProperties);
+
+        when(legacyConfigProperties.getAddressBook()).thenReturn(new AddressBook());
+    }
+}

platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/util/BootstrapUtils.java

@@ -41,6 +41,7 @@
 import com.swirlds.platform.config.PathsConfig;
 import com.swirlds.platform.config.internal.ConfigMappings;
 import com.swirlds.platform.config.internal.PlatformConfigUtils;
+import com.swirlds.platform.config.legacy.ConfigurationException;
 import com.swirlds.platform.gui.WindowConfig;
 import com.swirlds.platform.health.OSHealthCheckConfig;
 import com.swirlds.platform.health.OSHealthChecker;
@@ -372,11 +373,13 @@ public static void writeSettingsUsed(@NonNull final Configuration configuration)
 
         for (final NodeId nodeId : nodesToRun) {
             if (!addressBook.contains(nodeId)) {
+                final String errorMessage = "Node " + nodeId + " is not in the address book and cannot be started.";
                 // all nodes to start must exist in the address book
-                logger.error(
-                        EXCEPTION.getMarker(), "Node {} is not in the address book and cannot be started.", nodeId);
-                exitSystem(
-                        NODE_ADDRESS_MISMATCH, "Node " + nodeId + " is not in the address book and cannot be started.");
+                logger.error(EXCEPTION.getMarker(), errorMessage);
+                exitSystem(NODE_ADDRESS_MISMATCH, errorMessage);
+                // the following throw is not reachable in production,
+                // but reachable in testing with static mocked system exit calls.
+                throw new ConfigurationException(errorMessage);
             }
         }