-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support universal fallback for throttles.json genesis loading #17179
Conversation
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm @nathanklick !
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17179 +/- ##
============================================
- Coverage 64.34% 64.34% -0.01%
Complexity 20927 20927
============================================
Files 2552 2552
Lines 96041 96049 +8
Branches 10048 10049 +1
============================================
Hits 61799 61799
- Misses 30609 30615 +6
- Partials 3633 3635 +2
|
…17179) Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
Description
bootstrap.throttleDefsJson.file
configuration optionbootstrap.throttleDefsJson.resource
configuration optiongenesis/throttles.json
classpath resource, if thebootstrap.throttleDefsJson.file
and thebootstrap.throttleDefsJson.resource
files are not presentRelated Issues
Required Cherry Picks
release/0.58