Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support universal fallback for throttles.json genesis loading #17179

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

nathanklick
Copy link
Contributor

@nathanklick nathanklick commented Dec 30, 2024

Description

  • Adds a new bootstrap.throttleDefsJson.file configuration option
    • This config specifies the optional file on disk containing throttles to be loaded during genesis
  • Changes the bootstrap.throttleDefsJson.resource configuration option
    • This config now only specifies the optional classpath resource containing throttles to be loaded during genesis
  • Adds a universal fallback to the loading mechanism which defaults to loading mainnet values from the genesis/throttles.json classpath resource, if the bootstrap.throttleDefsJson.file and the bootstrap.throttleDefsJson.resource files are not present

Related Issues

Required Cherry Picks

  • release/0.58

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick nathanklick requested a review from a team as a code owner December 30, 2024 17:01
@nathanklick nathanklick self-assigned this Dec 30, 2024
Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @nathanklick !

@nathanklick nathanklick added this to the v0.58 milestone Dec 30, 2024
@nathanklick nathanklick added Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P0 An issue impacting production environments or impacting multiple releases or multiple individuals. labels Dec 30, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 36.36%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fc6027d) 95804 65240 68.10%
Head commit (4c1f66e) 95812 (+8) 65242 (+2) 68.09% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17179) 11 4 36.36%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.34%. Comparing base (fc6027d) to head (4c1f66e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...app/service/file/impl/schemas/V0490FileSchema.java 27.27% 7 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17179      +/-   ##
============================================
- Coverage     64.34%   64.34%   -0.01%     
  Complexity    20927    20927              
============================================
  Files          2552     2552              
  Lines         96041    96049       +8     
  Branches      10048    10049       +1     
============================================
  Hits          61799    61799              
- Misses        30609    30615       +6     
- Partials       3633     3635       +2     
Files with missing lines Coverage Δ
...a/com/hedera/node/config/data/BootstrapConfig.java 100.00% <ø> (ø)
...app/service/file/impl/schemas/V0490FileSchema.java 88.80% <27.27%> (-1.67%) ⬇️

... and 1 file with indirect coverage changes

Impacted file tree graph

@nathanklick nathanklick merged commit 346ac64 into main Dec 30, 2024
62 of 71 checks passed
@nathanklick nathanklick deleted the 17177-Genesis-Throttles branch December 30, 2024 19:04
nathanklick added a commit that referenced this pull request Dec 30, 2024
…17179)

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P0 An issue impacting production environments or impacting multiple releases or multiple individuals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading genesis throttles.json should have universal fallback
2 participants