Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version/1.0.2 #3

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Version/1.0.2 #3

merged 2 commits into from
Jul 11, 2022

Conversation

hide-your-code
Copy link
Owner

✏️ TODO

(List your doing in your pull request here)

  • Update README.md.
  • Add PULL_REQUEST_TEMPLATE.md.
  • Create the unit test sample.
  • Now, I'm using StateFlow instead of Channel<Event>. We can't using Channel<Event> to handle one-off event.
  • Fix bug in SevenDaysWeatherScreen.

📘 Libraries

(List your libraries that you add or modifier in your pull request)

  • MockK.
  • Kotlin Reflection.
  • Kotlin Kover.

🔔 Notes

(You must provides some information such as how to testing your pull request because this is important for your reviewer to check your pull request)

  • Using ./gradlew koverHtmlReport to generate the unit test coverage. It will be in app/build/kover_report/index.html.

📷 Screenshots

(Add some screenshots in here)

The unit test coverage

Screen Shot 2022-07-11 at 15 03 14

@hide-your-code hide-your-code added bug Something isn't working enhancement New feature or request v1.0.2 For version v1.0.2 labels Jul 11, 2022
@hide-your-code hide-your-code self-assigned this Jul 11, 2022
@hide-your-code hide-your-code changed the title V1.0.2 Version/1.0.2 Jul 11, 2022
@hide-your-code hide-your-code merged this pull request into master Jul 11, 2022
@hide-your-code hide-your-code deleted the v1.0.2 branch July 11, 2022 08:06
hide-your-code added a commit that referenced this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request v1.0.2 For version v1.0.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant