Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local #222

Merged
merged 10 commits into from
Apr 25, 2022
Merged

Fix local #222

merged 10 commits into from
Apr 25, 2022

Conversation

mbkumar
Copy link
Collaborator

@mbkumar mbkumar commented Apr 22, 2022

This PR changes fix_all to local_fix_all and adds a replacement fix_all that fixes global DOFs.

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #222 (166ea85) into master (079c4db) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   90.82%   90.83%           
=======================================
  Files          59       59           
  Lines        7725     7733    +8     
=======================================
+ Hits         7016     7024    +8     
  Misses        709      709           
Flag Coverage Δ
unittests 90.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/simsopt/_core/optimizable.py 90.10% <100.00%> (+0.14%) ⬆️
src/simsopt/mhd/profiles.py 98.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 079c4db...166ea85. Read the comment docs.

Copy link
Contributor

@landreman landreman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

In the readthedocs tutorials (example_coils.rst, example_islands.rst, example_quasisymmetry.rst, example_vmec_only.rst), can we use fix_all() instead of local_fix_all() and use unfix_all() instead of local_unfix_all()? The shorter function names are more intuitive and work equally well here I think.

I took the liberty of adding a bit to the docs page optimizable.rst about the new functions. Feel free to edit.

@landreman landreman self-requested a review April 24, 2022 19:05
@mbkumar mbkumar merged commit 30abd3f into master Apr 25, 2022
@mbkumar mbkumar deleted the fix_local branch April 25, 2022 14:09
@mbkumar mbkumar mentioned this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants