-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix local #222
Conversation
…o [un]fix global dofs
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
=======================================
Coverage 90.82% 90.83%
=======================================
Files 59 59
Lines 7725 7733 +8
=======================================
+ Hits 7016 7024 +8
Misses 709 709
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent.
In the readthedocs tutorials (example_coils.rst
, example_islands.rst
, example_quasisymmetry.rst
, example_vmec_only.rst
), can we use fix_all()
instead of local_fix_all()
and use unfix_all()
instead of local_unfix_all()
? The shorter function names are more intuitive and work equally well here I think.
I took the liberty of adding a bit to the docs page optimizable.rst
about the new functions. Feel free to edit.
This PR changes
fix_all
tolocal_fix_all
and adds a replacementfix_all
that fixes global DOFs.