Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contest tags #8230

Merged
merged 18 commits into from
Jun 28, 2024
Merged

Contest tags #8230

merged 18 commits into from
Jun 28, 2024

Conversation

masvelio
Copy link
Contributor

@masvelio masvelio commented Jun 24, 2024 •
edited
Loading

Link to Issue

Closes: #7940

Description of Changes

  • with @kurtisassad we adjusted queries in get_bulk_threads.ts and get_threads_by_id.ts to provide FE with contest/score data
  • hooked up data into existing ThreadContestTag component (with some small refactoring)

image

image

Test Plan

  • create contest (oneoff or recurring)
  • fund it (direct deposit vs buying stake)
  • create thread
  • upvote it
  • wait till the end of the contest
  • when contest is finished, next to thread title you should see the tag with the proper place in the contest (1st, 2nd, 3rd etc)

@masvelio masvelio force-pushed the marcin/7940-contest-tags branch from 2b92ac0 to a5c8495 Compare June 25, 2024 10:43
@masvelio masvelio marked this pull request as ready for review June 25, 2024 10:51
rbennettcw
rbennettcw reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@rbennettcw rbennettcw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but main thing is the query.

packages/commonwealth/client/scripts/models/Thread.ts Outdated Show resolved Hide resolved
packages/commonwealth/server/controllers/server_threads_methods/get_bulk_threads.ts Outdated Show resolved Hide resolved
@rbennettcw rbennettcw self-requested a review June 27, 2024 19:02
@masvelio masvelio mentioned this pull request Jun 28, 2024
Open
@masvelio masvelio merged commit 8133d89 into master Jun 28, 2024
8 of 9 checks passed
@masvelio masvelio deleted the marcin/7940-contest-tags branch June 28, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachben91 sachben91 sachben91 left review comments

@timolegros timolegros timolegros left review comments

@mzparacha mzparacha mzparacha approved these changes

@rbennettcw rbennettcw rbennettcw approved these changes

@kurtisassad kurtisassad Awaiting requested review from kurtisassad

@Israellund Israellund Awaiting requested review from Israellund

@burtonator burtonator Awaiting requested review from burtonator

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contest - Wire up contest thread tag
6 participants
@masvelio @kurtisassad @sachben91 @mzparacha @timolegros @rbennettcw