Skip to content

Modifying pastis poisson #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 21, 2020
Merged

Conversation

gesinecauer
Copy link
Collaborator

Integrating the changes we'd discussed:

  • Removing redundant MDS utils functions from utils_diploid.py
  • Renaming "pastis diploid" to "pastis poisson" (and "utils_diploid to "utils_poisson", etc)
  • Minor updates to installation instructions

@codecov
Copy link

codecov bot commented Jan 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c8ad557). Click here to learn what that means.
The diff coverage is 2.91%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #65   +/-   ##
=========================================
  Coverage          ?   14.89%           
=========================================
  Files             ?       48           
  Lines             ?     3767           
  Branches          ?        0           
=========================================
  Hits              ?      561           
  Misses            ?     3206           
  Partials          ?        0
Impacted Files Coverage Δ
pastis/optimization/piecewise_whole_genome.py 0% <0%> (ø)
pastis/externals/iced/setup.py 0% <0%> (ø)
pastis/optimization/utils_poisson.py 0% <0%> (ø)
pastis/optimization/estimate_alpha_beta.py 0% <0%> (ø)
pastis/setup.py 0% <0%> (ø)
pastis/optimization/initialization.py 0% <0%> (ø)
pastis/optimization/load_data.py 0% <0%> (ø)
pastis/optimization/callbacks.py 0% <0%> (ø)
pastis/optimization/pastis_algorithms.py 0% <0%> (ø)
pastis/optimization/counts.py 0% <0%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ad557...dcf3b6f. Read the comment docs.

Copy link
Contributor

@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@NelleV NelleV merged commit 16ee5d6 into hiclib:master Jan 21, 2020
@gesinecauer gesinecauer deleted the modifying_pastis_poisson branch January 21, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants