Conversation
|
Thanks, I'll review it properly soon, I promise! |
|
@destan do you think there's a way we could do this without adding a hard dependency to Spring? I mean, in principle it's enough just to know the name of the annotation. |
|
spring dependencies are only required for tests, there is no hard spring dependency for the Normally spring dependencies should be test scoped is there anything I overlooked? |
Sure, but I would prefer that this project didn't have a dependency to Spring. |
|
By the way, if you're worried about it breaking in tests, you could just add an annotation with the same name as the Spring |
I didn't think of that in the first place, let me update the PR according to this approach and make it free of any spring dependencies. |
|
Great, thanks! |
@Queryannotation of Spring Data JPA.nativeQuery = trueon the annotationcountQueryon the annotation yet.tried to follow the repository's coding style and conventions as much as I can but I can fix things if you point them on comments.