-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add spring data jpa @Query support #22
base: master
Are you sure you want to change the base?
Conversation
Thanks, I'll review it properly soon, I promise! |
@destan do you think there's a way we could do this without adding a hard dependency to Spring? I mean, in principle it's enough just to know the name of the annotation. |
spring dependencies are only required for tests, there is no hard spring dependency for the Normally spring dependencies should be test scoped is there anything I overlooked? |
Sure, but I would prefer that this project didn't have a dependency to Spring. |
By the way, if you're worried about it breaking in tests, you could just add an annotation with the same name as the Spring |
I didn't think of that in the first place, let me update the PR according to this approach and make it free of any spring dependencies. |
Great, thanks! |
@Query
annotation of Spring Data JPA.nativeQuery = true
on the annotationcountQuery
on the annotation yet.tried to follow the repository's coding style and conventions as much as I can but I can fix things if you point them on comments.