Skip to content

[ORM] Add links to Quarkus docs on Jakarta Data #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: production
Choose a base branch
from

Conversation

marko-bekhta
Copy link
Member

The quickstart guide (commented out link) didn't get into this release, but it is already merged in the development branch, so it should get there eventually.

btw... this page mentions versions explicitly (e.g. 6.6 or 7) and I wonder if we should add some note/reminder somewhere (probably to the ORM release process?) to check/update the page, or we somehow link it to "current version of ORM?

@marko-bekhta marko-bekhta requested a review from gavinking May 5, 2025 14:39
@yrodiere
Copy link
Member

yrodiere commented May 6, 2025

btw... this page mentions versions explicitly (e.g. 6.6 or 7) and I wonder if we should add some note/reminder somewhere (probably to the ORM release process?) to check/update the page

Great way to have people not read this reminder, IMO :D

or we somehow link it to "current version of ORM?

Makes sense to me. You can use something like

- stable_series = latest_stable_series(real_page)
to retrieve the latest stable version.

Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this kind of link belongs on the Documentation page, not on the landing page. That's not info that we want to push directly into people's faces at that point.

@gavinking
Copy link
Member

gavinking commented May 13, 2025

That's not info that we want to push directly into people's faces at that point.

Actually I take that back. It's fine to have the link, just not in that way. Add the link to a word like "add" or "as dependencies".

@marko-bekhta marko-bekhta force-pushed the docs/add-quarkus-links-to-data-repositories-page branch from 100b7c9 to 92118b3 Compare June 6, 2025 16:11
@marko-bekhta marko-bekhta force-pushed the docs/add-quarkus-links-to-data-repositories-page branch from 92118b3 to 7793cc6 Compare June 6, 2025 16:14
@marko-bekhta
Copy link
Member Author

ok, I've updated the pr. Just adding the annotation processor jar as a dependency actually is not entirely correct way to do annotation processing, as the processor should be configured in the compiler plugin instead (for maven; and with annotationProcessor for gradle)... so this should be better (I think 😉)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants