HV-2114 Add support for Korean foreigner RRN validation #1642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcalmsky
commented
Jun 9, 2025
| @@ -90,7 +99,7 @@ private static boolean isValidDate(final String rrn) { | |||
| if ( month < 1 || month > 12 || day < 1 || day > 31 ) { | |||
| return false; | |||
| } | |||
| return day <= 31 && ( day <= 30 || ( month != 4 && month != 6 && month != 9 && month != 11 ) ) && ( day <= 29 || month != 2 ); | |||
| return (day <= 30 || month != 4 && month != 6 && month != 9 && month != 11) && (day <= 29 || month != 2); | |||
There was a problem hiding this comment.
Simplified the conditional statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for Korean Resident Registration Numbers (RRNs) issued to foreign residents living in Korea.
Currently, the KorRRNValidator rejects RRNs with gender digits 5 to 8, which represent foreign males and females born in the 1900s and 2000s:
By adding these digits to the
GENDER_DIGITlist, this validator now correctly accepts valid RRNs for foreign residents.Jira Issue: HV-2114
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on licensing, please check here.