Skip to content

HV-1831 experiments (6.2) #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
HV-1831 : Experiment detecting cycles in bean classes
Add test for Map
  • Loading branch information
gbadner committed Apr 30, 2021
commit d4a4f4ca3da10e5cb15f9604f342921187bf1786
Original file line number Diff line number Diff line change
@@ -0,0 +1,189 @@
/*
* Hibernate Validator, declare and validate application constraints
*
* License: Apache License, Version 2.0
* See the license.txt file in the root directory or <http://www.apache.org/licenses/LICENSE-2.0>.
*/
package org.hibernate.validator.test.internal.engine.tracking;

import java.util.Arrays;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Map;
import java.util.Set;
import javax.validation.ConstraintViolation;
import javax.validation.Valid;
import javax.validation.Validation;
import javax.validation.Validator;
import javax.validation.constraints.NotNull;

import org.hibernate.validator.PredefinedScopeHibernateValidator;
import org.hibernate.validator.PredefinedScopeHibernateValidatorFactory;
import org.hibernate.validator.internal.engine.PredefinedScopeValidatorFactoryImpl;
import org.hibernate.validator.internal.engine.ValidatorFactoryScopedContext;
import org.hibernate.validator.internal.engine.tracking.ProcessedBeansTrackingStrategy;

import org.testng.annotations.Test;

import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertTrue;

/**
* An example of beans with cascading constraints, some cycle and others do not.
*
* A -> B ---> C ------> F -> G <-
* | ^ | ^ ^ |
* | | | | | |
* | -- D <-- | | |
* --------------------> E -------
*
* A, B, C, D, E, F, and G are beans that get validated.
*
* An arrow, ->, indicates a cascading constraint.ProcessedBeansTrackingCyclesNoCyclesMapTest
*
* The following are the properties with cascading Map constraints:
* A.bToEs
* B.cToCs
* C.dToFs
* D.bToBs
* E.fToGs
* .gToGs
* F.gToGs
*
* @author Gail Badner
*
*/

public class ProcessedBeansTrackingCyclesNoCyclesMapTest {

@Test
public void testTrackingEnabled() {

final ValidatorFactoryScopedContext validatorFactoryScopedContext = getValidatorFactoryScopedContext();
final ProcessedBeansTrackingStrategy processedBeansTrackingStrategy =
validatorFactoryScopedContext.getProcessedBeansTrackingStrategy();
assertTrue( processedBeansTrackingStrategy.isEnabledForBean(
A.class,
true
) );
assertTrue( processedBeansTrackingStrategy.isEnabledForBean(
B.class,
true
) );
assertTrue( processedBeansTrackingStrategy.isEnabledForBean(
C.class,
true
) );
assertTrue( processedBeansTrackingStrategy.isEnabledForBean(
D.class,
true
) );
assertFalse( processedBeansTrackingStrategy.isEnabledForBean(
E.class,
true
) );
assertFalse( processedBeansTrackingStrategy.isEnabledForBean(
F.class,
true
) );
assertFalse( processedBeansTrackingStrategy.isEnabledForBean(
G.class,
false
) );
}

@Test
public void testValidate() {
final A a = new A();
final B b = new B();
final C c = new C();
final D d = new D();
final E e = new E();
final F f = new F();
final G g = new G();

a.bToEs.put( b, e );
b.cToCs.put( c, c );
c.dToFs.put( d, f );
d.bToBs.put( b, b );
e.fToGs.put( f, g );
e.gToGs.put( g, g );

final Validator validator = getValidator();
final Set<ConstraintViolation<A>> violationsA = validator.validate( a );
final Set<ConstraintViolation<B>> violationsB = validator.validate( b );
final Set<ConstraintViolation<C>> violationsC = validator.validate( c );
final Set<ConstraintViolation<D>> violationsD = validator.validate( d );
final Set<ConstraintViolation<E>> violationsE = validator.validate( e );
final Set<ConstraintViolation<F>> violationsF = validator.validate( f );
final Set<ConstraintViolation<G>> violationsG = validator.validate( g );
}

private Validator getValidator() {
return getValidatorFactory().getValidator();
}

private PredefinedScopeHibernateValidatorFactory getValidatorFactory() {
return Validation.byProvider( PredefinedScopeHibernateValidator.class )
.configure()
.builtinConstraints( new HashSet<>( Arrays.asList( NotNull.class.getName() ) ) )
.initializeBeanMetaData( new HashSet<>( Arrays.asList(
A.class, B.class, C.class, D.class, E.class, F.class, G.class
) ) )
.buildValidatorFactory().unwrap( PredefinedScopeHibernateValidatorFactory.class );
}

private ValidatorFactoryScopedContext getValidatorFactoryScopedContext() {
return ( (PredefinedScopeValidatorFactoryImpl) getValidatorFactory() ).getValidatorFactoryScopedContext();
}

private static class A {

private String description;

private Map<@Valid B, @Valid E> bToEs = new HashMap<>();

}

private static class B {
@Valid
private String description;

private Map<@Valid C, @Valid C> cToCs = new HashMap<>();
}

private static class C {

private String description;

private Map<@Valid D, @Valid F> dToFs = new HashMap<>();
}

private static class D {

private String description;

private Map<@Valid B, @Valid B> bToBs = new HashMap<>();
}

private static class E {

private String description;

private Map<@Valid F, G> fToGs = new HashMap<>();

private Map<@Valid G, @Valid G> gToGs = new HashMap<>();
}

private static class F {

private String description;

private Map<@Valid G, @Valid G> gToGs = new HashMap<>();
}

private static class G {

private String description;
}
}