automatic driver selection from URI

[gavinking]

@aguibert did some work to automate the selection of the database driver when creating a Pool. Currently we still have a legacy workaround for 3.9.1. We need to clean that up.

UPDATE:
Vert.x now has a way to do this. See: eclipse-vertx/vertx-sql-client#1101
To close this issue, at first glance, we need:

• More tests related to how we extract the options from the URL (Relates to Test SqlConnectOptions creation from URL #1059)
• Remove DefaultSqlClientPoolConfiguration.
• Update or remove UriPoolConfiguration in favor of the new approach.

[gavinking]

eclipse-vertx/vertx-sql-client#616

[gavinking]

Hrrrrm. @aguibert I was looking at this fragment of code in SqlClientPool:

		catch (ServiceConfigurationError e) {
			// Backup option if multiple drivers are on the classpath.
			// We will be able to remove this once Vertx 3.9.2 is available
			return findDriver( uri, e ).createPool( vertx, connectOptions, poolOptions );
		}

It seems to imply that we should now be able to delete the findDriver() method.

But actually it doesn't seem to be the case. On 3.9.2, it seems that the fallback stuff is still needed.

Can you clarify, please?

[gavinking]

Hrrrrm, I've just noticed that DB2ConnectOptions, MySQLConnectOptions, and PgConnectOptions all have a fromUri() method which parses a connection string.

I wonder if it would be better to use these connection strings than the JDBC URLs we've been using up to now.

It would be ideal if Vert.x offered a SqlConnectionOptions.forUri(String) method, but even without that we could iterate over the loaded Drivers and find one which accepts the given connection string.

WDYT @aguibert @DavideD @Sanne @vietj?

[gavinking]

I wonder if it would be better to use these connection strings than the JDBC URLs we've been using up to now.

I've actually demonstrated what that would look like, via the new SqlClientPoolConfiguration (which I added for a different reason).

https://github.com/hibernate/hibernate-reactive/blob/42937a41097a0e974c06d134f956488df7a4fecc/hibernate-reactive-core/src/test/java/org/hibernate/reactive/UriPoolConfiguration.java

[gavinking]

I need eclipse-vertx/vertx-sql-client#767 to make progress on this.