Skip to content

HHH-7135 Tests for derived identity with joined inheritance #9610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

HHH-7135 Tests for derived identity with joined inheritance #9610

wants to merge 2 commits into from

Conversation

beikov
Copy link
Member

@beikov beikov commented Jan 13, 2025 •
edited by hibernate-github-bot bot
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

https://hibernate.atlassian.net/browse/HHH-7135

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 13, 2025
View reviewed changes
...g/hibernate/orm/test/annotations/derivedidentities/DerivedIdentityJoinedInheritanceTest.java

@Entity(name = "AThing")
@Inheritance(strategy = InheritanceType.JOINED)
public abstract class AThing {

Check notice

Code scanning / CodeQL

Inner class could be static Note test

AThing should be made static, since the enclosing instance is not used.
...g/hibernate/orm/test/annotations/derivedidentities/DerivedIdentityJoinedInheritanceTest.java
}

@Entity(name = "ThingHolder")
public class ThingHolder {

Check notice

Code scanning / CodeQL

Inner class could be static Note test

ThingHolder should be made static, since the enclosing instance is not used.
...g/hibernate/orm/test/annotations/derivedidentities/DerivedIdentityJoinedInheritanceTest.java
}

@Entity(name = "Thing1")
public class Thing1 extends AThing {

Check notice

Code scanning / CodeQL

Inner class could be static Note test

Thing1 should be made static, since the enclosing instance is not used.
...g/hibernate/orm/test/annotations/derivedidentities/DerivedIdentityJoinedInheritanceTest.java
}

@Entity(name = "Thing2")
public class Thing2 extends AThing {

Check notice

Code scanning / CodeQL

Inner class could be static Note test

Thing2 should be made static, since the enclosing instance is not used.
...t/java/org/hibernate/orm/test/annotations/derivedidentities/MapsIdJoinedInheritanceTest.java

@Entity(name = "AThing")
@Inheritance(strategy = InheritanceType.JOINED)
public abstract class AThing {

Check notice

Code scanning / CodeQL

Inner class could be static Note test

AThing should be made static, since the enclosing instance is not used.
...t/java/org/hibernate/orm/test/annotations/derivedidentities/MapsIdJoinedInheritanceTest.java
}

@Entity(name = "Thing2")
public class Thing2 extends AThing {

Check notice

Code scanning / CodeQL

Inner class could be static Note test

Thing2 should be made static, since the enclosing instance is not used.
...est/java/org/hibernate/orm/test/annotations/derivedidentities/MapsIdUnownedOneToOneTest.java

@Entity(name = "AThing")
@Inheritance(strategy = InheritanceType.JOINED)
public abstract class AThing {

Check notice

Code scanning / CodeQL

Inner class could be static Note test

AThing should be made static, since the enclosing instance is not used.
...est/java/org/hibernate/orm/test/annotations/derivedidentities/MapsIdUnownedOneToOneTest.java
}

@Entity(name = "ThingHolder")
public class ThingHolder {

Check notice

Code scanning / CodeQL

Inner class could be static Note test

ThingHolder should be made static, since the enclosing instance is not used.
...est/java/org/hibernate/orm/test/annotations/derivedidentities/MapsIdUnownedOneToOneTest.java
}

@Entity(name = "Thing1")
public class Thing1 extends AThing {

Check notice

Code scanning / CodeQL

Inner class could be static Note test

Thing1 should be made static, since the enclosing instance is not used.
...est/java/org/hibernate/orm/test/annotations/derivedidentities/MapsIdUnownedOneToOneTest.java
}

@Entity(name = "Thing2")
public class Thing2 extends AThing {

Check notice

Code scanning / CodeQL

Inner class could be static Note test

Thing2 should be made static, since the enclosing instance is not used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
JIRA issue Test Case
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@beikov