add a method for use by quarkus extension #8786
Conversation
Signed-off-by: Gavin King <gavin@hibernate.org>
Signed-off-by: Gavin King <gavin@hibernate.org>
Looks like it should be called WDYT? |
| @Internal | ||
| // called by the Quarkus extension | ||
| public MetadataImpl trim() { | ||
| return new MetadataImpl( | ||
| getUUID(), | ||
| getMetadataBuildingOptions(), //TODO Replace this | ||
| getEntityBindingMap(), | ||
| getComposites(), | ||
| getGenericComponentsMap(), | ||
| getEmbeddableDiscriminatorTypesMap(), | ||
| getMappedSuperclassMap(), | ||
| getCollectionBindingMap(), | ||
| getTypeDefinitionMap(), | ||
| getFilterDefinitions(), | ||
| getFetchProfileMap(), | ||
| getImports(), // ok | ||
| getIdGeneratorDefinitionMap(), | ||
| getNamedQueryMap(), | ||
| getNamedNativeQueryMap(), // TODO might contain references to org.hibernate.loader.custom.ConstructorResultColumnProcessor, org.hibernate.type.TypeStandardSQLFunction | ||
| getNamedProcedureCallMap(), | ||
| getSqlResultSetMappingMap(), //TODO might contain NativeSQLQueryReturn (as namedNativeQueryMap above) | ||
| getNamedEntityGraphs(), //TODO reference to *annotation* instance ! FIXME or ignore feature? | ||
| getSqlFunctionMap(), // ok | ||
| getDatabase(), // Cleaned up: used to include references to MetadataBuildingOptions, etc. | ||
| getBootstrapContext() //FIXME WHOA! | ||
| ); | ||
| } |
gavinking
changed the title
|
As discussed over Zulip, this is just one of many places where the integration between Quarkus and Hibernate ORM is very tight, to the point of being fragile, and that's the reason we only support running Quarkus with the exact version of Hibernate ORM it references in its BOM. We can merge this if you want, but IMO it only makes sense if we also add a test to check that |
|
Also FWIW |
Which is why I added a comment. The main issue is that the constructor that Quarkus was calling was not even commented as such. |
Fair enough. LGTM, though I think changes that impact code we ship need a Jira issue, so we'll need to add that before merging. |
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.