HHH-16578 - Add test and fix for issue #6548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hibernate-core/src/test/java/org/hibernate/orm/test/tool/schema/MySQLColumnValidationTest.java
Fixed
Show fixed
Hide fixed
|
This is not a bug. Property level is 32 bit integer (java.lang.Integer or primitive int), but corresponding column is tinyint which can accept only 8 bit numbers (see MySQL documentation). After changing type of property level from int to byte validation will pass without problems. |
jrenaat
force-pushed
the
HHH-16578_mysqlcolumnvalidationerror
branch
from
a872f04 to
f327753
Compare
jrenaat
changed the title
jrenaat
force-pushed
the
HHH-16578_mysqlcolumnvalidationerror
branch
from
f327753 to
1e742d3
Compare
jrenaat
force-pushed
the
HHH-16578_mysqlcolumnvalidationerror
branch
from
1e742d3 to
0bb3b48
Compare
beikov
reviewed
May 17, 2023
hibernate-core/src/main/java/org/hibernate/tool/schema/internal/ColumnDefinitions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
…ion (less dependant on columnDefinition info, and more on the use of @JdbcTypeCode) Signed-off-by: Jan Schatteman <jschatte@redhat.com>
jrenaat
force-pushed
the
HHH-16578_mysqlcolumnvalidationerror
branch
from
0bb3b48 to
31ff2cc
Compare
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
beikov
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.