Repository navigation
HHH-21002 Handle JSON-B API without a provider - #13706
Open
lucamolteni wants to merge 1 commit into
Open
lucamolteni wants to merge 1 commit into
lucamolteni wants to merge 1 commit into
Conversation
2 tasks done
|
|
||
| @BeforeEach | ||
| void rememberContextClassLoader() { | ||
| originalContextClassLoader = Thread.currentThread().getContextClassLoader(); |
Member
There was a problem hiding this comment.
maybe try looking at @ExtendWith(ClassLoadingIsolaterExtension.class) ? (I'd rather we try keeping those CL sort of tests using the same infra if possible 🤞🏻🙂)
Comment on lines
+39
to
+44
| catch (JsonbException e) { | ||
| if ( e.getCause() instanceof ClassNotFoundException ) { | ||
| // The API is available, but its default provider is not. | ||
| return null; | ||
| } | ||
| throw e; |
Member
There was a problem hiding this comment.
Suggested change
| catch (JsonbException e) { | |
| if ( e.getCause() instanceof ClassNotFoundException ) { | |
| // The API is available, but its default provider is not. | |
| return null; | |
| } | |
| throw e; | |
| catch (JsonbException e) { | |
| log.debug(...,e); | |
| return null; |
the docs only seem to talk about JsonbException so maybe let's just log and move on ?
Documentation PreviewDocumentation preview artifact not found for commit 6f22f7e. View workflow run for details. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Jira: https://hibernate.atlassian.net/browse/HHH-21002
Reported in quarkusio/quarkus#57388.
Verification
./gradlew formatChecks :hibernate-core:test --tests org.hibernate.orm.test.type.format.JakartaJsonIntegrationTests --tests 'org.hibernate.orm.test.mapping.basic.JsonMappingTests$*'passes: 24 focused tests on bothmainand8.0.8.0.0-SNAPSHOTsuccessfully builds the Quarkus issue's native reproducer with local Quarkus999-SNAPSHOTand GraalVM CE 25.0.2, without adding Yasson orquarkus-jsonb. The original build with ORM8.0.0.Beta3fails during native-image analysis.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
Please make sure that the following tasks are completed:
Tasks specific to HHH-21002 (Bug):
migration-guide.adocOR check there are no breaking changes