HHH-20955 Fix reuse of binding parameter across several attributes

[HiMyNameIsIlNano]

Fix reuse of binding parameter across several attributes sharing an AttributeConverter

A JPQL query that compares several entity attributes against one single named parameter fails to bind when the attributes are mapped with the same @convert(converter = ...), whose relational type is not one of the types BindingTypeHelper.resolveTimestampTemporalTypeVariant knows, and the parameter is used three or more times across at least two different such attributes.

Here we have a two-steps issue. The QueryParameterBindingImpl#setType re-checks on each further use of a parameter within a query whether the new attribute is compatible with the previous one, and bails out to NullType when it is not. The compatibility check compares value converters by reference identity (i.e. using ==). So four attributes carrying the very same converter class end up with four distinct converter instances . This way two structurally identical attributes are judged incompatible, and Hibernate drops the inferred type (binding it to NullType).

Once this is done (and the binding is NullType) JdbcParameterBindings#createAndAddBinding resolves the type by the value runtime class. As the AttributeConverter has already done its job at that point, the OffsetDateTime has become a LocalDateTime, and BindingTypeHelper#resolveTimestampTemporalTypeVariant throws an error not being able to handle LocalDateTime (allowed values are Calendar, java.util.Date, Instant, OffsetDateTime, ZonedDateTime).

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

---

---

Please make sure that the following tasks are completed:
Tasks specific to HHH-20955 (Bug):

• Add test reproducing the bug
• Add entries as relevant to migration-guide.adoc OR check there are no breaking changes

https://hibernate.atlassian.net/browse/HHH-20955

[hibernate-github-bot]

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.