-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-19843 Get persister from session factory if session is not available #11067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marko-bekhta
wants to merge
1
commit into
hibernate:main
Choose a base branch
from
marko-bekhta:fix/HHH-19843-Bean-Validation-may-fail-on-operations-with-stateless-session
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
109 changes: 109 additions & 0 deletions
109
...bernate/orm/test/annotations/beanvalidation/CollectionActionsValidationStatelessTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,109 @@ | ||
/* | ||
* SPDX-License-Identifier: Apache-2.0 | ||
* Copyright Red Hat Inc. and Hibernate Authors | ||
*/ | ||
package org.hibernate.orm.test.annotations.beanvalidation; | ||
|
||
import jakarta.persistence.Entity; | ||
import jakarta.persistence.Id; | ||
import jakarta.persistence.JoinColumn; | ||
import jakarta.persistence.ManyToOne; | ||
import jakarta.persistence.OneToMany; | ||
import jakarta.persistence.Table; | ||
import jakarta.validation.ConstraintViolationException; | ||
import jakarta.validation.constraints.Size; | ||
import org.hibernate.cfg.AvailableSettings; | ||
import org.hibernate.testing.orm.junit.DomainModel; | ||
import org.hibernate.testing.orm.junit.Jira; | ||
import org.hibernate.testing.orm.junit.ServiceRegistry; | ||
import org.hibernate.testing.orm.junit.SessionFactory; | ||
import org.hibernate.testing.orm.junit.SessionFactoryScope; | ||
import org.hibernate.testing.orm.junit.Setting; | ||
import org.junit.jupiter.api.AfterEach; | ||
import org.junit.jupiter.api.Test; | ||
|
||
import java.util.ArrayList; | ||
import java.util.List; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
import static org.junit.jupiter.api.Assertions.assertThrows; | ||
|
||
@SessionFactory | ||
@DomainModel(annotatedClasses = { | ||
CollectionActionsValidationStatelessTest.Author.class, | ||
CollectionActionsValidationStatelessTest.Book.class, | ||
}) | ||
@ServiceRegistry(settings = @Setting(name = AvailableSettings.JAKARTA_VALIDATION_MODE, value = "auto")) | ||
@Jira("https://hibernate.atlassian.net/browse/HHH-19843") | ||
public class CollectionActionsValidationStatelessTest { | ||
|
||
@Test | ||
void smoke(SessionFactoryScope scope) { | ||
scope.inStatelessTransaction( session -> { | ||
final ConstraintViolationException e = assertThrows( ConstraintViolationException.class, () -> { | ||
ArrayList<Book> books = new ArrayList<>(); | ||
Author author = new Author( 1L, "first", "last", books ); | ||
Book book = new Book( 10L, "", author ); | ||
books.add( book ); | ||
|
||
session.upsertMultiple( List.of( author ) ); | ||
} ); | ||
assertThat( e.getConstraintViolations() ).hasSize( 1 ); | ||
} ); | ||
} | ||
|
||
@AfterEach | ||
public void tearDown(SessionFactoryScope scope) { | ||
scope.getSessionFactory().getSchemaManager().truncate(); | ||
} | ||
|
||
@Table(name = "author") | ||
@Entity | ||
static class Author { | ||
|
||
public Author() { | ||
} | ||
|
||
public Author(long id, String firstName, String lastName, List<Book> books) { | ||
this.firstName = firstName; | ||
this.lastName = lastName; | ||
this.books = books; | ||
this.id = id; | ||
} | ||
|
||
@Id | ||
Long id; | ||
|
||
String firstName; | ||
|
||
String lastName; | ||
|
||
@OneToMany | ||
@JoinColumn(name = "bookId") | ||
@Size(min = 10) | ||
List<Book> books; | ||
|
||
} | ||
|
||
@Table(name = "book") | ||
@Entity | ||
static class Book { | ||
|
||
public Book() { | ||
} | ||
|
||
public Book(long id, String title, Author author) { | ||
this.id = id; | ||
this.title = title; | ||
this.author = author; | ||
} | ||
|
||
@Id | ||
Long id; | ||
|
||
String title; | ||
|
||
@ManyToOne | ||
Author author; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fine workaround, but I wonder if we could rather make
org.hibernate.event.spi.AbstractSessionEvent
take aorg.hibernate.engine.spi.SharedSessionContractImplementor
instead oforg.hibernate.event.spi.EventSource
, deprecating the old signature (and delegating to the new one sinceEventSource
extendsSharedSessionContractImplementor
.Since stateless session fire this events too now, it would make more sense to be able to retrieve them in
AbstractSessionEvent#getSession
(which, as the name implies, could not only returnEventSource
s). Perhaps let's hear what @gavinking thinks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 there is the
hibernate-orm/hibernate-core/src/main/java/org/hibernate/event/spi/AbstractEvent.java
Lines 18 to 19 in 1753cb6
but it's a different hierarchy of events, and these collection ones don't get the same source 😖