HHH-19824: Db2z dialect sequences fixed #11006
Conversation
…ke sequence alias' into consideration when reading these
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
hibernate-core/src/main/java/org/hibernate/dialect/DB2zDialect.java
Outdated
Show resolved
Hide resolved
|
Thanks for your contribution. Once you applied the changes I asked for, please squash to a single commit including the HHH Jira issue key in the commit message and rebase the PR. |
dankristensen
changed the title
|
Nice, now please squash to a single commit and rebase the PR. |
…ke sequence alias' into consideration when reading these
mostly just use of 'var'
This fixes issues with ScopeTests when running against CockroachDB. Also remove test skips that were due to locking not working correctly. See cockroachdb/cockroach#88995 for details
…ystem properties but also configuration properties
…ristensen/hibernate-orm into DB2zDialect_sequences_fixed HHH-19824: Fixed sequences on DB2 zOS
|
I think i did it in a bad way. How do i fix this @beikov |
|
Read an article about Git rebase: https://git-scm.com/book/en/v2/Git-Branching-Rebasing The steps I usually do are: git fetch upstreamTo fetch the changes from the upstream repository in my local mirror. git rebase upstream/mainTo do the actual rebase. If there are conflicts, you have to resolve them and then git push -fFinally, push the changes to your remote repository with |
DB2zDialect did not support proper DB2 sequences on zOS
This change ensures that it is possible to use sequences even if some of these are aliases.
According to the documentation here: https://www.ibm.com/docs/en/db2-for-zos/12.0.0?topic=spaces-syssequences, the seqtype is important for parsing the sequences correctly for an alias.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-99999
https://hibernate.atlassian.net/browse/HHH-19752