HHH-14584 Allow PhysicalNamingStrategy implementations to detect when a name is implicit or explicit #10366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
reviewed
Jun 17, 2025
hibernate-core/src/main/java/org/hibernate/boot/internal/InFlightMetadataCollectorImpl.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/internal/AnnotatedColumn.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/internal/EntityBinder.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/naming/Identifier.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/id/enhanced/SequenceStyleGenerator.java
Outdated
Show resolved
Hide resolved
… a name is implicit or explicit
peter1123581321
force-pushed
the
HHH-14584
branch
from
f3a867d to
f2c18e7
Compare
beikov
approved these changes
Jun 30, 2025
|
Hey @peter1123581321 , it looks like your PR isn't passing tests on all DBs. Also, since it's been a while (sorry) it's now conflicting with the Could you please rebase, force push, and have a look at test results to see what needs fixing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HHH-14584, an additional field was requested in
Identifierto indicate explicit namings of columns.This would allow more possibilies in a custom
PhysicalNamingStrategy.As
PhysicalNamingStrategyalso provides methods for sequences and tables, this PR also implements handling explicit namings of both of them.However, I did not provide it for schemas and catalogs.
Many thanks in advance for feedback, comments and change requests. :)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-14584