fix: fix normalizeReferenceId
#99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
hi-ogawa
commented
Jul 22, 2024
| @@ -226,7 +226,7 @@ function vitePluginUseClient(): PluginOption { | |||
| } | |||
| manager.clientReferenceMap.delete(id); | |||
| if (code.includes("use client")) { | |||
| const runtimeId = await normalizeReferenceId(id, "react-server"); | |||
| const runtimeId = await normalizeReferenceId(id, "client"); | |||
There was a problem hiding this comment.
It looks like this was a simple typo, but then I'm not sure what's happening in hi-ogawa/vite-plugins#297 since there's no equivalent logic.
hi-ogawa
changed the title
normalizeReferenceId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is supposed to pass, but it looks like this is failing since #97.
The difference is obvious from terminal log when changing
"use client"files:Also note that similar "absolute path" issue is happening when testing Vite 6 in Vite 5 RSC hi-ogawa/vite-plugins#297 even though these two use a different approach.