Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

清理工单上线内和engines无关的代码,各方法在engines中实现,工单只负责状态流转,方便接入不同数据库 #92

Merged
merged 4 commits into from
Apr 1, 2019

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented Mar 30, 2019

  • 将工单检测和提交都完全交给engine实现
  • 自动审批判断增加实例数据库类型判断,暂时还未并入engine

@request-info
Copy link

request-info bot commented Mar 30, 2019

请按照对应模本提交/修改,不规范的issue将直接关闭

@codecov
Copy link

codecov bot commented Mar 30, 2019

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   68.43%   68.43%           
=======================================
  Files          61       61           
  Lines        6085     6085           
=======================================
  Hits         4164     4164           
  Misses       1921     1921
Impacted Files Coverage Δ
sql/sql_workflow.py 50.54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ffefc9...037f233. Read the comment docs.

@LeoQuote
Copy link
Collaborator

LeoQuote commented Mar 30, 2019

哈哈哈哈哈哈,机器人都看不下去了

加个标签,不然会被关的哈哈哈哈

@hhyo hhyo added enhancement New feature or request help wanted Extra attention is needed and removed 请提供更多信息 labels Mar 31, 2019
@hhyo hhyo force-pushed the workflow_code_optimization branch from 037f233 to 9a193a7 Compare April 1, 2019 16:02
@hhyo hhyo marked this pull request as ready for review April 1, 2019 16:05
@hhyo hhyo merged commit 7f0d598 into master Apr 1, 2019
@hhyo hhyo deleted the workflow_code_optimization branch April 1, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants