Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis添加会话管理支持 #2816

Merged
merged 33 commits into from
Sep 20, 2024

Conversation

feiazifeiazi
Copy link
Contributor

@feiazifeiazi feiazifeiazi commented Sep 19, 2024

  1. 会话管理-进程状态 列表添加Redis支持。(processlist方法提升为父类)

好想把tests.py的每个类单独一个文件出来。
d5abc1e79eca4c8d839f05d6241d7ba6

示例效果:

image

列表字段:
Id (id),
远程地址 (addr),
本地地址 (laddr),
客户端名称 (name),
用户 (user),
数据库 (db),
连接耗时(秒) (age),
空闲时间(秒) (idle),
命令 (cmd),
总内存 (tot-mem),
输出内存 (omem),
标志 (flags),
文件描述符 (fd),
订阅数 (sub),
模式订阅数 (psub),
MULTI 队列长度 (multi),
查询缓冲区 (qbuf),
查询缓冲区空闲 (qbuf-free),
参数内存 (argv-mem),
输出缓冲区长度 (obl),
输出链长度 (oll),
事件文件 (events),
重定向 (redir)

@LeoQuote
Copy link
Collaborator

base 有点过时了, 辛苦 rebase 解决下冲突

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.31%. Comparing base (b1efe08) to head (ab3981f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sql/db_diagnostic.py 0.00% 2 Missing ⚠️
sql/engines/__init__.py 50.00% 1 Missing ⚠️
sql/engines/cloud/aliyun_rds.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2816      +/-   ##
==========================================
+ Coverage   78.25%   78.31%   +0.05%     
==========================================
  Files         124      124              
  Lines       17492    17512      +20     
==========================================
+ Hits        13689    13714      +25     
+ Misses       3803     3798       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nick2wang
Copy link
Collaborator

好像少了终止会话的部分?

@feiazifeiazi
Copy link
Contributor Author

好像少了终止会话的部分?

等下一版。不敢改多。

image

@feiazifeiazi
Copy link
Contributor Author

base 有点过时了, 辛苦 rebase 解决下冲突

@LeoQuote 好了。 可以了,给看一下。

LeoQuote
LeoQuote previously approved these changes Sep 20, 2024
Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿 tests 是以前写的都堆在里面了,优化也是可以优化的,推荐多试试pytest,我自己的体验的话,比 python 自带的unittest要简洁一些

我看逻辑基本上没问题,覆盖率也达标

@LeoQuote LeoQuote merged commit 58c0145 into hhyo:master Sep 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants