[Fix] Fix ssh tunnel always return 127.0.0.1 #2808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修复ssh隧道始终返回127.0.0.1，改为动态获取本地地址
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2808 +/- ##
==========================================
- Coverage 78.05% 78.05% -0.01%
==========================================
Files 122 122
Lines 17286 17290 +4
==========================================
+ Hits 13493 13495 +2
- Misses 3793 3795 +2 ☔ View full report in Codecov by Sentry. |
LeoQuote
previously approved these changes
Sep 14, 2024
LeoQuote
reviewed
Sep 14, 2024
sql/utils/tests.py
Outdated
Comment on lines
1520
to
1526
| def test_get_local_ip(mocker: MockerFixture): | ||
| from sql.utils.ssh_tunnel import SSHTunnelForwarder | ||
|
|
||
| mock_start = mocker.patch.object(SSHTunnelForwarder, "start") | ||
| tunnel = SSHConnection("mysql", 3306, "tunnel", 22, "root", "password", "", "") | ||
| assert tunnel.get_local_ip() != "127.0.0.1" | ||
| assert mock_start.assert_called_once() |
There was a problem hiding this comment.
@bwcxyk 你能像这样描述下你的预期吗? 我这边测试这个结果返回就是 127.0.0.1 , 你要不按之前的实现, 从环境变量里读监听地址
There was a problem hiding this comment.
那什么环境下不返回 127？ 能否描述下你的预期？
There was a problem hiding this comment.
那什么环境下不返回 127？ 能否描述下你的预期？
如果机器没连接网络是会返回127.0.0.1的，python获取本地主机IP地址都是这个方法。
我在Archery容器中测试了是正常的。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复ssh隧道始终返回127.0.0.1，改为动态获取本地地址