-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
修复mongo上线问题 #2803
修复mongo上线问题 #2803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的代码复用有点少, 能否帮忙优化一下, 渲染时先做无用户名密码的情况, 然后有用户名密码就加上对应的参数
#2805 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2803 +/- ##
==========================================
+ Coverage 78.05% 78.11% +0.05%
==========================================
Files 122 123 +1
Lines 17286 17331 +45
==========================================
+ Hits 13493 13538 +45
Misses 3793 3793 ☔ View full report in Codecov by Sentry. |
lint 必须要修好哈 |
这里修复了lint问题了,可以看看了 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多谢贡献, build_cmd 这块逻辑有点多容易出错, 能否帮忙加一下单元测试, 因为只是字符串操作测试加起来应该不难, 请参考历史的单元测试或者 https://github.com/hhyo/Archery/wiki/development
这里历史只看到开发环境的搭建过程,不知道这个测试具体是如何操作?没有做过测试,可否细致描述一下具体流程? |
这样应该是测试加入完成了?有空可以瞅瞅 |
看完了没问题👌🏿 |
在使用未开启密码认证的实例上,会出现mongo的上线报错,因为代码中强制使用了账号密码登录的方式
找到了之前的#1893,加入几个判断可以解决,我改好了提了个pr
fix #2789