-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
修复归档工单无法获取到资源组的问题 #2779
base: master
Are you sure you want to change the base?
修复归档工单无法获取到资源组的问题 #2779
Conversation
你好!感谢你反馈的问题/bug,但是你的描述好像是空的,我们需要你完整的信息,这样才能帮你解决问题 如果不知道怎么写,在新建issue的时候有若干个模板可供选择,祝好! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2779 +/- ##
==========================================
+ Coverage 77.85% 78.07% +0.21%
==========================================
Files 122 122
Lines 16892 17307 +415
==========================================
+ Hits 13151 13512 +361
- Misses 3741 3795 +54 ☔ View full report in Codecov by Sentry. |
def test_archive_init_no_resource_group(archive_apply): | ||
"""测试 archive 初始化时指定的资源组不存在""" | ||
with pytest.raises(AuditException) as e: | ||
AuditV2(workflow=archive_apply, resource_group="not_exists_group") | ||
assert "参数错误, 未发现资源组" in str(e.value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? 怎么把这个测试删掉了, 这种情况需要考虑的吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果时通过resource_group_id来获取resource_group的话,这里好像不存在资源组不存在的情况?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个你说的可能不太现实, 你可以确认下前端是传名字还是 ID, 你如果想要做这个功能, 你要确认前端是只传 ID, 不然可能会造成混淆, 我当时是重构的时候为了防止出错原样照搬了, 如果你想优化流程, 你需要去确认这个影响范围.
No description provided.