Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复归档工单无法获取到资源组的问题 #2779

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

woshiyanghai
Copy link
Contributor

No description provided.

Copy link

request-info bot commented Sep 2, 2024

你好!感谢你反馈的问题/bug,但是你的描述好像是空的,我们需要你完整的信息,这样才能帮你解决问题 如果不知道怎么写,在新建issue的时候有若干个模板可供选择,祝好!

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.07%. Comparing base (83c9664) to head (107e36f).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2779      +/-   ##
==========================================
+ Coverage   77.85%   78.07%   +0.21%     
==========================================
  Files         122      122              
  Lines       16892    17307     +415     
==========================================
+ Hits        13151    13512     +361     
- Misses       3741     3795      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines -360 to -364
def test_archive_init_no_resource_group(archive_apply):
"""测试 archive 初始化时指定的资源组不存在"""
with pytest.raises(AuditException) as e:
AuditV2(workflow=archive_apply, resource_group="not_exists_group")
assert "参数错误, 未发现资源组" in str(e.value)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? 怎么把这个测试删掉了, 这种情况需要考虑的吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果时通过resource_group_id来获取resource_group的话,这里好像不存在资源组不存在的情况?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个你说的可能不太现实, 你可以确认下前端是传名字还是 ID, 你如果想要做这个功能, 你要确认前端是只传 ID, 不然可能会造成混淆, 我当时是重构的时候为了防止出错原样照搬了, 如果你想优化流程, 你需要去确认这个影响范围.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants