-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES与OpenSearch数据源添加SQL上线功能支持-v0.7-beta #2768
The head ref may contain hidden characters: "\u652F\u6301ES\u7684\u6267\u884C\u64CD\u4F5C"
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2768 +/- ##
==========================================
+ Coverage 77.85% 78.08% +0.23%
==========================================
Files 122 122
Lines 16892 17311 +419
==========================================
+ Hits 13151 13518 +367
- Misses 3741 3793 +52 ☔ View full report in Codecov by Sentry. |
现在还是覆盖率没达标, 我有一个提议, 现在 engine 实际上比较自由, 你可以尝试去做一个 python 的 package, 然后发布到 pypi 上, archery 去装你的包, 然后加载, 就可以达到同样的效果. 好处在代码和发布都是你来控制, CI, 覆盖率, 你想做就做. 当然我也清楚这些代码就不属于 archery 了, 我理解社区就是这样, 我自己也想把 archery 的比较独立的部分能够独立出去, 建立起来一个比较良好的, 可插拔的框架, 方便更多人的定制, 也方便更多人基于这个平台做更多有益于数据安全的事情. |
覆盖率问题是因为单元测试方法还没开始写。 |
@LeoQuote 帮忙审一下。 |
ES和OpenSearch支持上线功能。
示例语句: