Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

实例配置增加默认字符集 #274

Merged
merged 1 commit into from
Jun 16, 2019
Merged

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented Jun 15, 2019

关联issue:#158 #214 #249

  • 实例配置中新增字符集字段,可为空
  • 为空时mysql默认使用utf8mb4,mssql默认使用UTF8

@hhyo hhyo requested a review from LeoQuote June 15, 2019 08:14
@LeoQuote
Copy link
Collaborator

oracle 和pg的要怎么设置?

@hhyo
Copy link
Owner Author

hhyo commented Jun 15, 2019

不了解,所以是保持现状

@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #274 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   83.75%   83.75%   +<.01%     
==========================================
  Files          65       65              
  Lines        8410     8411       +1     
==========================================
+ Hits         7044     7045       +1     
  Misses       1366     1366
Impacted Files Coverage Δ
sql/completer/mysql.py 100% <ø> (ø) ⬆️
sql/engines/mysql.py 91.16% <ø> (ø) ⬆️
sql/models.py 94.92% <100%> (ø) ⬆️
sql/engines/goinception.py 91.3% <100%> (ø) ⬆️
sql/engines/mssql.py 84.17% <100%> (ø) ⬆️
sql/engines/inception.py 88.62% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09390ee...6e1959f. Read the comment docs.

@hhyo hhyo force-pushed the feature/add-default-charset branch from 4a2571b to 6e1959f Compare June 16, 2019 07:47
@hhyo hhyo merged commit 877ec2e into master Jun 16, 2019
@hhyo hhyo deleted the feature/add-default-charset branch June 16, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants