Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加配置项控制是否获取dml真实影响行数 #2454

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

nick2wang
Copy link
Collaborator

@nick2wang nick2wang commented Dec 12, 2023

增加配置项REAL_ROW_COUNT,控制是否获取dml真实影响行数,从历史issues来看应该有不少人需要用到

  1. mysql是通过goinception的real_row_count调用选项实现(https://hanchuanchuan.github.io/goInception/params.html)
  2. mongo我之前提交的pr(mongo engine优化 #2018)里默认开启,现在改为配置项开关控制是否启用

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (22e37cd) 76.83% compared to head (bd32df1) 76.97%.

Files Patch % Lines
sql/engines/mongo.py 60.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2454      +/-   ##
==========================================
+ Coverage   76.83%   76.97%   +0.14%     
==========================================
  Files         115      115              
  Lines       15886    15944      +58     
==========================================
+ Hits        12206    12273      +67     
+ Misses       3680     3671       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeoQuote
Copy link
Collaborator

其实goinception 开启更方便一些,要不写个文档算了

@nick2wang
Copy link
Collaborator Author

其实goinception 开启更方便一些,要不写个文档算了

我之前的表述有误,real_row_count属于goinception的调用选项并非参数,只能在调用时指定,无法预设默认开启,对于archery用户来说要使用只能自己去改代码

@LeoQuote
Copy link
Collaborator

原来如此, 那补一下单元测试这个就可以merge 了

@nick2wang nick2wang merged commit 10cadc9 into hhyo:master Dec 13, 2023
10 checks passed
@nick2wang nick2wang deleted the real-row-count branch May 11, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants