Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复查询 tab 随意跳转的 bug #2412

Merged
merged 6 commits into from
Nov 26, 2023
Merged

Conversation

LeoQuote
Copy link
Collaborator

@LeoQuote LeoQuote commented Nov 24, 2023

fix #2290
fix #2267

主要问题都是 #2230 没有还原之前的逻辑

有几个问题:

  1. let 的作用域仅在当前的大括号内, 所以应该预先定义, 后续重新赋值
  2. 相同表结构查看没有复用结果tab
  3. 各个引擎的自定义显示没有复刻

这几个问题都已经修复了, mongo 的表结构显示也看了下, 现在可以正常显示了

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73c93e6) 76.37% compared to head (271ad95) 76.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2412   +/-   ##
=======================================
  Coverage   76.37%   76.37%           
=======================================
  Files         115      115           
  Lines       15824    15824           
=======================================
  Hits        12085    12085           
  Misses       3739     3739           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hhyo
Copy link
Owner

hhyo commented Nov 25, 2023

看了下#2230 应该主要为了解决多数据引擎的optgroup自动填充问题,可以在原基础上仅调整这一部分,否则得考虑下面这几个细节处理的修复

  • pg schema选项没有展示
  • redis 没有隐藏表选择
  • 美化按钮和执行计划没有按需禁用展示
  • 相同表结构查看没有复用结果tab
  • 直接使用show create table 查询表结构时没有修改tab标题为表名称
  • 除了已修复的引擎,mongo也有表结构无法正常展示的问题
  • 还有就是这个pr对应的tab跳转问题

可能还有其他已经遗忘的细节... 😂

@LeoQuote
Copy link
Collaborator Author

给我两三周我来试试,争取把这些bug都修了发个新版

@LeoQuote LeoQuote marked this pull request as draft November 25, 2023 10:31
@LeoQuote LeoQuote marked this pull request as ready for review November 25, 2023 15:43
@LeoQuote LeoQuote requested a review from hhyo November 25, 2023 16:19
@hhyo hhyo merged commit f483213 into hhyo:master Nov 26, 2023
10 checks passed
@LeoQuote LeoQuote deleted the fix_query_frontend branch November 26, 2023 02:30
finovy pushed a commit to finovy/Archery that referenced this pull request Dec 1, 2023
* 修复查询 tab 随意跳转的 bug

* fix syntax

* 恢复大部分针对引擎的自定义代码, 整理为配置-渲染的模式, 方便复用

* 优化 redis 帮助手册的代码风格

* 禁用 cassandra 的 explain

* 修复"相同表结构查看没有复用结果tab" bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants